From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: ab/unpack-trees-leakfix
Date: Wed, 13 Oct 2021 15:33:19 +0200 [thread overview]
Message-ID: <877dehhwuq.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqv9239k15.fsf@gitster.g>
On Mon, Oct 11 2021, Junio C Hamano wrote:
> * ab/unpack-trees-leakfix (2021-10-07) 2 commits
> - unpack-trees: don't leak memory in verify_clean_subdirectory()
> - Merge branch 'ab/sanitize-leak-ci' into ab/unpack-trees-leakfix
>
> Leakfix.
>
> Will merge to 'next'?
I think it's ready, but I see you peeled of the 2nd and 3rd patch. I
re-rolled a v3 which should address Elijah's outstanding comments there:
with
https://lore.kernel.org/git/cover-v3-0.3-00000000000-20211013T132223Z-avarab@gmail.com/
I can submit that after this one if you'd like, but having that missing
clear_unpack_trees_porcelain() seems easy enough, and will make that API
and its users leak-free.
next prev parent reply other threads:[~2021-10-13 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 0:14 What's cooking in git.git (Oct 2021, #03; Mon, 11) Junio C Hamano
2021-10-12 22:07 ` Submodules UX overhaul update (was: What's cooking in git.git (Oct 2021, #03; Mon, 11)) Emily Shaffer
2021-10-13 5:20 ` Atharva Raykar
2021-10-13 13:28 ` ab/mark-leak-free-tests Ævar Arnfjörð Bjarmason
2021-10-13 13:33 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-13 13:43 ` What's cooking in git.git (Oct 2021, #03; Mon, 11) Ævar Arnfjörð Bjarmason
2021-10-13 13:47 ` ab/parse-options-cleanup Ævar Arnfjörð Bjarmason
2021-10-13 22:35 ` What's cooking in git.git (Oct 2021, #03; Mon, 11) Junio C Hamano
2021-10-14 14:42 ` js/retire-preserve-merges, was " Johannes Schindelin
2021-10-14 15:50 ` Ævar Arnfjörð Bjarmason
2021-10-14 17:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dehhwuq.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).