git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: New command/tool: git filter-repo
Date: Fri, 08 Feb 2019 19:53:32 +0100	[thread overview]
Message-ID: <875ztukt77.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CABPp-BFC--s+D0ijRkFCRxP5Lxfi+__YF4EdxkpO5z+GoNW7Gg@mail.gmail.com>


On Thu, Jan 31 2019, Elijah Newren wrote:

> What's the future?  (Core command of git.git?  place it in contrib?  keep it
> in a separate repo?)  I'm hoping to discuss that at the contributor summit
> today, but feedback on the list is also welcome.

Some of this I may have mentioned at the summit, but here for the list:

* I think it should be a candidate for a core (not "just contrib")
  git.git command, given that we have someone willing to maintain it &
  deal with bugs etc. I'm not worried about that given the author.

* It's unfortunate in terms of API we need to support going forward that
  this obligates us to support a fairly intricate python API going
  forward, so it's similar (but more detailed) to Git.pm (which I also
  tried to get rid of as an external API a while ago).

  However, as you correctly note that's the only way a command like this
  can be really fast, we already have the "no special API" command with
  git-filter-branch, and that's horribly slow.

  But perhaps there's ways we can in advance deal with a potential
  future breaking API change. E.g. some Pythonic way of versioning the
  API, or just prominently documenting whatever (low?) stability
  guarantees we're making.

  I imagine if we need to make breaking changes in the future that'll
  less big of a deal than in other cases, since we'd expect the API use
  to be one-off migration scripts, although maybe it'll get used for
  all-the-time exports (e.g. mirroring internal->external repos with
  filtering).

* The rest of our commands are hooked up to the i18n framework. I don't
  think this should be a blocker, but it's worth thinking about what the
  plan for this is.

  Are we going to need the equivalent of Git::I18N for Python (which
  presumably will be a run-time dependency on something needing the
  Python API that links to gettext).

  Or perhaps we could do the translated strings in C, by making the
  program you're invoking be a C command, invoking the Python part as a
  helper (which would need to re-invoke a helper if it prints its own
  messages).

Thanks for working on this!

  parent reply	other threads:[~2019-02-08 18:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  8:57 New command/tool: git filter-repo Elijah Newren
2019-01-31 19:09 ` Junio C Hamano
2019-01-31 20:43   ` Elijah Newren
2019-01-31 23:36     ` Roberto Tyley
2019-02-01  7:38       ` Elijah Newren
2019-01-31 20:47 ` Elijah Newren
2019-02-08  1:25 ` Elijah Newren
2019-02-08 10:22   ` Johannes Schindelin
2019-02-08 18:53 ` Ævar Arnfjörð Bjarmason [this message]
2019-02-08 20:13   ` Johannes Schindelin
2019-02-11 16:00     ` Elijah Newren
2019-02-11 15:47   ` Elijah Newren
2019-06-08 16:20   ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ztukt77.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).