From: Leah Neukirchen <leah@vuxu.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH v4] help: colorize man pages
Date: Thu, 20 May 2021 16:39:42 +0200 [thread overview]
Message-ID: <875yzda2q9.fsf@vuxu.org> (raw)
In-Reply-To: <20210520040725.133848-1-felipe.contreras@gmail.com> (Felipe Contreras's message of "Wed, 19 May 2021 23:07:25 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> So, in order for this change to have any effect:
>
> 1. The user must use less
> 2. Not have the LESS variable set
> 3. Have color.ui enabled
> 4. Not have color.pager disabled
> 5. Not have color.man disabled
> 6. Not have NO_COLOR set
> 7. Not have git with stdout directed to a file
I can't review the code thoroughly right now, but if it works as
described here, +1 from me.
--
Leah Neukirchen <leah@vuxu.org> https://leahneukirchen.org
prev parent reply other threads:[~2021-05-20 14:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 4:07 [PATCH v4] help: colorize man pages Felipe Contreras
2021-05-20 9:26 ` Phillip Wood
2021-05-20 13:58 ` Felipe Contreras
2021-05-20 15:13 ` Phillip Wood
2021-05-20 15:59 ` Felipe Contreras
2021-05-20 18:00 ` Phillip Wood
2021-05-21 17:43 ` Felipe Contreras
2021-05-21 5:06 ` Junio C Hamano
2021-05-21 8:44 ` Jeff King
2021-05-21 18:01 ` Felipe Contreras
2021-05-21 20:26 ` Jeff King
2021-05-21 21:40 ` Felipe Contreras
2021-05-22 9:55 ` Jeff King
2021-05-22 12:43 ` Philip Oakley
2021-05-22 20:53 ` Felipe Contreras
2021-05-22 20:49 ` Felipe Contreras
2021-05-21 17:54 ` Felipe Contreras
2021-05-20 14:39 ` Leah Neukirchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yzda2q9.fsf@vuxu.org \
--to=leah@vuxu.org \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).