git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael Witten <mfwitten@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Thomas Rast <trast@student.ethz.ch>,
	Pierre Habouzit <madcoder@debian.org>,
	Pascal Obry <pascal@obry.net>, Jay Soffian <jaysoffian@gmail.com>,
	David Brown <git@davidb.org>, Matthew Wilcox <matthew@wil.cx>,
	"Robin H. Johnson" <robbat2@gentoo.org>,
	git@vger.kernel.org
Subject: Re: [PATCH RESEND] send-email: add 'specify-author' option
Date: Thu, 12 Apr 2012 15:59:41 -0000	[thread overview]
Message-ID: <87520431c0b04cd4b78aac481d81002b-mfwitten@gmail.com> (raw)
In-Reply-To: <7vobr4ze5z.fsf@alter.siamese.dyndns.org>

On Fri, 06 Apr 2012 15:30:32 -0700, Junio C Hamano wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> I can't foresee that, but I guess we can do it anyway. So which would
>> be the fields to repeat? From, Date, and Subject?
> 
> I would say From and Subject are equally worth considering.

Famous last words: "I can't foresee that."

My impression from Junio's initial comment:

>>> The first paragraph of the proposed commit log message states the problem
>>> it tries to address very clearly, which is good, but is "From: " the only
>>> thing that needs this?  I am wondering if this should be named and behave
>>> more like "--duplicate-header" or "--in-body-header".

is that a more general solution should be sought, particularly because we
indeed can't foresee people's needs. I envisioned `--in-body-header' taking
as an argument a colon-separated list of headers that should be inlined;
let the user mix and match as he pleases, and save us trouble in the
future when new headers pop up (I can't forsee that happening, but, well,
who knows?).

Naturally, a configuration variable could be useful.

Sincerely,
Michael Witten

  parent reply	other threads:[~2012-04-12 16:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 12:21 [PATCH RESEND] send-email: add 'specify-author' option Felipe Contreras
2012-04-06 12:32 ` Felipe Contreras
2012-04-06 17:14 ` Junio C Hamano
2012-04-06 19:42   ` Felipe Contreras
2012-04-06 20:22     ` Junio C Hamano
2012-04-06 21:48       ` Felipe Contreras
2012-04-06 22:30         ` Junio C Hamano
2012-04-07 11:46           ` Felipe Contreras
2012-04-08  4:45             ` Junio C Hamano
2012-04-12 15:59           ` Michael Witten [this message]
2012-04-12 15:41     ` Michael Witten
2012-04-12 17:40       ` Junio C Hamano
2012-04-06 19:47 ` Thomas Rast
2012-04-06 21:30   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87520431c0b04cd4b78aac481d81002b-mfwitten@gmail.com \
    --to=mfwitten@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@davidb.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jaysoffian@gmail.com \
    --cc=madcoder@debian.org \
    --cc=matthew@wil.cx \
    --cc=pascal@obry.net \
    --cc=robbat2@gentoo.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).