From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Stan Hu <stanhu@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, luke@diamand.org,
pclouds@gmail.com
Subject: Re: Bug in "revision.c: --all adds HEAD from all worktrees" ?
Date: Tue, 13 Mar 2018 21:29:11 +0100 [thread overview]
Message-ID: <874lljg1ns.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <C62FA8BB-FDCA-4BD0-A029-74C7AB89441F@gmail.com>
On Tue, Mar 13 2018, Stan Hu jotted:
> To be clear, this is how I think we got into this state:
>
> We have worktrees that are created to squash and rebase a branch. They were left around inadvertently for one reason or another.
>
> Since we were using git v2.14.3, a git gc would prune dangling objects because it never saw that a worktree still had a reference to it. Now, in git v2.15+, worktrees are examined, and a git gc won't garbage collect any objects referenced by a worktree.
>
> Another words, the failure of git v2.14 to preserve these objects caused problems with these stale worktrees with the upgrade to v2.15+.
Thanks, I hadn't dug into the root cause. Good to know it's not some
failure mode we're still producing, just the result of past bugs.
next prev parent reply other threads:[~2018-03-13 20:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:23 Bug in "revision.c: --all adds HEAD from all worktrees" ? Stan Hu
2018-03-13 20:29 ` Ævar Arnfjörð Bjarmason [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-13 19:51 Luke Diamand
2017-11-13 22:03 ` Luke Diamand
2017-11-13 22:15 ` Stefan Beller
2017-11-15 21:38 ` Luke Diamand
2017-11-17 22:03 ` Jeff King
2017-11-15 22:08 ` Junio C Hamano
2017-11-16 1:06 ` Luke Diamand
2018-03-12 21:39 ` Ævar Arnfjörð Bjarmason
2018-03-13 11:22 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lljg1ns.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
--cc=pclouds@gmail.com \
--cc=stanhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).