From: "Ævar Arnfjörð Bjarmason" <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: email@example.com, "SZEDER Gábor" <firstname.lastname@example.org>, "Junio C Hamano" <email@example.com> Subject: Re: [PATCH 1/9] t7415: remove out-dated comment about translation Date: Mon, 03 May 2021 11:46:52 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <YI12n+1rbedpwyfW@coredump.intra.peff.net> On Sat, May 01 2021, Jeff King wrote: > Since GETTEXT_POISON does not exist anymore, there is no point warning > people about whether we should use test_i18ngrep. This is doubly > confusing because the comment was describing why it was OK to use grep, > but it got caught up in the mass conversion of 674ba34038 (fsck: mark > strings for translation, 2018-11-10). > > Note there are other uses of test_i18ngrep in this script which are now > obsolete; I'll save those for a mass-cleanup. My goal here was just to > fix the confusing comment in code I'm about to refactor. For what it's worth between  and  I'm not sure what to do about the test_i18ngrep cleanup. I think your patch below is fine, but the "test_i18ngrep" has mutated into a "grep with debugging", not just something needed for GETTEXT_POISON. So that part of your patch right now is making it less friendly for debugging. I don't care, and think if we want that we'd be better of scraping the trace ouput for such common cases and/or use "verbose grep [...]" and teach the "verbose" wrapper about these common cases, but knowing of that objection + having other outstanding things has been why I haven't sent s/test_i18ngrep/grep/g patches. 1. https://lore.kernel.org/git/20210120152132.GC8396@szeder.dev/ 2. https://email@example.com/ > Signed-off-by: Jeff King <firstname.lastname@example.org> > --- > t/t7415-submodule-names.sh | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/t/t7415-submodule-names.sh b/t/t7415-submodule-names.sh > index f70368bc2e..fef6561d80 100755 > --- a/t/t7415-submodule-names.sh > +++ b/t/t7415-submodule-names.sh > @@ -151,10 +151,9 @@ test_expect_success 'fsck detects symlinked .gitmodules file' ' > } | git mktree && > > # Check not only that we fail, but that it is due to the > - # symlink detector; this grep string comes from the config > - # variable name and will not be translated. > + # symlink detector > test_must_fail git fsck 2>output && > - test_i18ngrep gitmodulesSymlink output > + grep gitmodulesSymlink output > ) > '
next prev parent reply other threads:[~2021-05-03 9:53 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-01 15:40 [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics Jeff King 2021-05-01 15:41 ` [PATCH 1/9] t7415: remove out-dated comment about translation Jeff King 2021-05-03 9:46 ` Ævar Arnfjörð Bjarmason [this message] 2021-05-03 20:29 ` Jeff King 2021-05-01 15:41 ` [PATCH 2/9] fsck_tree(): fix shadowed variable Jeff King 2021-05-03 11:15 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:13 ` Jeff King 2021-05-04 10:10 ` Ævar Arnfjörð Bjarmason 2021-05-01 15:41 ` [PATCH 3/9] fsck_tree(): wrap some long lines Jeff King 2021-05-03 11:22 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:23 ` Jeff King 2021-05-01 15:42 ` [PATCH 4/9] t7415: rename to expand scope Jeff King 2021-05-01 15:42 ` [PATCH 5/9] t7450: test verify_path() handling of gitmodules Jeff King 2021-05-01 18:55 ` Eric Sunshine 2021-05-01 19:03 ` Eric Sunshine 2021-05-03 19:39 ` Jeff King 2021-05-03 10:12 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:32 ` Jeff King 2021-05-01 15:42 ` [PATCH 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King 2021-05-01 15:42 ` [PATCH 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King 2021-05-01 15:43 ` [PATCH 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King 2021-05-01 15:43 ` [PATCH 9/9] docs: document symlink restrictions for dot-files Jeff King 2021-05-01 19:16 ` Eric Sunshine 2021-05-03 20:33 ` Jeff King 2021-05-03 5:36 ` [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics Junio C Hamano 2021-05-03 20:42 ` [PATCH v2 " Jeff King 2021-05-03 20:43 ` [PATCH v2 1/9] t7415: remove out-dated comment about translation Jeff King 2021-05-03 20:43 ` [PATCH v2 2/9] fsck_tree(): fix shadowed variable Jeff King 2021-05-03 20:43 ` [PATCH v2 3/9] fsck_tree(): wrap some long lines Jeff King 2021-05-03 20:43 ` [PATCH v2 4/9] t7415: rename to expand scope Jeff King 2021-05-03 20:43 ` [PATCH v2 5/9] t7450: test verify_path() handling of gitmodules Jeff King 2021-05-03 20:43 ` [PATCH v2 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King 2021-05-03 20:43 ` [PATCH v2 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King 2021-05-03 20:43 ` [PATCH v2 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King 2021-05-03 20:43 ` [PATCH v2 9/9] docs: document symlink restrictions for dot-files Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/9] t7415: remove out-dated comment about translation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).