From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: Antw: [EXT] Re: git add --interactive patch improvement for split hunks
Date: Wed, 30 Jun 2021 10:27:16 +0200 [thread overview]
Message-ID: <874kdfg32w.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <YNwd6wmt4FTyySgH@coredump.intra.peff.net>
On Wed, Jun 30 2021, Jeff King wrote:
> On Tue, Jun 29, 2021 at 11:09:19PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > It looks like Junio carried it in "What's Cooking" for almost a
>> > year, marked as "waiting for re-roll" to handle the squash, but then
>> > eventually discarded it as stale. :(
>>
>> Heh, thanks for digging.
>>
>> Is the moral of the story that we should merge down unfinished
>> topics more aggressively (hoping that the untied loose ends would be
>> tied after they hit released version), we should prod owners of
>> stalled topics with sharper stick more often, or something else?
>
> I'm not sure. I think the topic would have graduated if either you had
> just applied the squash and merged it down, or if the original author
> had checked back in over the intervening year to say "hey, what happened
> to my patch" (either by reading "what's cooking" or manually).
>
> I suspect drive-by contributors might not realize they need to do the
> latter in some cases, but I wouldn't have counted 2014-era Ævar in that
> boat. So I dunno.
Or maybe the moral of the story that it's a net addition of complexity
to git-add--interactive.perl. If I didn't care enough to remember or
notice the issue again maybe it wasn't all that important to begin with.
Likewise when it got ejected nobody else seemed to notice/care enough to
say "hey I liked that feature" & to pick it up.
I'd entirely forgotten I wrote that. Now that I'm reminded of it I don't
care enough myself to rebase it, test it again, and especially not to
figure out if/how it's going to interact with the new C implementation /
add and adjust a test for the two.
But maybe someone else will, it would be neat if someone has more of an
itch from the lack of that feature & wants to pick it up.
next prev parent reply other threads:[~2021-06-30 8:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 10:35 git add --interactive patch improvement for split hunks Ulrich Windl
2021-06-24 15:41 ` Jeff King
2021-06-28 10:10 ` Antw: [EXT] " Ulrich Windl
2021-06-28 11:20 ` Ævar Arnfjörð Bjarmason
2021-06-30 2:16 ` Jeff King
2021-06-30 6:09 ` Junio C Hamano
2021-06-30 7:31 ` Jeff King
2021-06-30 8:27 ` Ævar Arnfjörð Bjarmason [this message]
2021-06-30 17:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kdfg32w.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Ulrich.Windl@rz.uni-regensburg.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).