From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: git@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 3/3] send-email: also pick up cc addresses from -by trailers
Date: Wed, 10 Oct 2018 14:51:45 +0200 [thread overview]
Message-ID: <8736teezha.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20181010111351.5045-4-rv@rasmusvillemoes.dk>
On Wed, Oct 10 2018, Rasmus Villemoes wrote:
> - next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;
> + next if $suppress_cc{'sob'} and $what =~ /^Signed-off-by$/i;
> + next if $suppress_cc{'misc-by'}
> + and $what =~ /-by$/i and $what !~ /^Signed-off-by$/i;
> next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
Looks good, FWIW I was curious if this could be:
next if $suppress_cc{'misc-by'} and $what =~ /(?<!^Signed-off)-by$/;
But found that as soon as you add a /i Perl will barf on it, and in any
case makes sense to be less clever about regex features.
next prev parent reply other threads:[~2018-10-10 12:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 11:13 [PATCH 0/3] send-email: Also pick up cc addresses from -by trailers Rasmus Villemoes
2018-10-10 11:13 ` [PATCH 1/3] Documentation/git-send-email.txt: style fixes Rasmus Villemoes
2018-10-10 11:13 ` [PATCH 2/3] send-email: only consider lines containing @ or <> for automatic Cc'ing Rasmus Villemoes
2018-10-10 12:57 ` Ævar Arnfjörð Bjarmason
2018-10-10 13:29 ` Rasmus Villemoes
2018-10-11 6:06 ` Junio C Hamano
2018-10-11 7:06 ` Rasmus Villemoes
2018-10-11 8:22 ` Junio C Hamano
2018-10-10 11:13 ` [PATCH 3/3] send-email: also pick up cc addresses from -by trailers Rasmus Villemoes
2018-10-10 12:51 ` Ævar Arnfjörð Bjarmason [this message]
2018-10-11 6:18 ` Junio C Hamano
2018-10-11 7:11 ` Rasmus Villemoes
2018-10-16 5:57 ` Junio C Hamano
2018-10-16 7:17 ` Rasmus Villemoes
2018-10-16 7:46 ` Junio C Hamano
2018-10-16 7:39 ` [PATCH v2 0/3] send-email: Also " Rasmus Villemoes
2018-10-16 7:39 ` [PATCH v2 1/3] Documentation/git-send-email.txt: style fixes Rasmus Villemoes
2018-10-16 7:39 ` [PATCH v2 2/3] send-email: only consider lines containing @ or <> for automatic Cc'ing Rasmus Villemoes
2018-10-16 7:39 ` [PATCH v2 3/3] send-email: also pick up cc addresses from -by trailers Rasmus Villemoes
2018-10-16 7:57 ` [PATCH v2 0/3] send-email: Also " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736teezha.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).