From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00, FROM_FMBLA_NEWDOM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id F0FE51F463 for ; Sat, 30 Nov 2019 20:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbfK3ULz (ORCPT ); Sat, 30 Nov 2019 15:11:55 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:55338 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726981AbfK3ULz (ORCPT ); Sat, 30 Nov 2019 15:11:55 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47QMwQ6Jx0z1rGRY; Sat, 30 Nov 2019 21:11:50 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47QMwQ5rPwz1qwZH; Sat, 30 Nov 2019 21:11:50 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id m5EpjZ-3N70y; Sat, 30 Nov 2019 21:11:49 +0100 (CET) X-Auth-Info: hU8qKVGJkAhnWkLToezXuu1tcAYDyONc+A679GOTPECFe9RvCIDffBu1TYH4p6o4 Received: from igel.home (ppp-46-244-176-84.dynamic.mnet-online.de [46.244.176.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 30 Nov 2019 21:11:49 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 3FAAD2C0102; Sat, 30 Nov 2019 21:11:48 +0100 (CET) From: Andreas Schwab To: Johannes Sixt Cc: Junio C Hamano , Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles References: <6beaf25f-1369-3e77-fd54-fdb5a1e63707@kdbg.org> X-Yow: I've got to get these SNACK CAKES to NEWARK by DAWN!! Date: Sat, 30 Nov 2019 21:11:48 +0100 In-Reply-To: <6beaf25f-1369-3e77-fd54-fdb5a1e63707@kdbg.org> (Johannes Sixt's message of "Sat, 30 Nov 2019 20:13:56 +0100") Message-ID: <8736e5t98b.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Nov 30 2019, Johannes Sixt wrote: > Am 30.11.19 um 19:04 schrieb Junio C Hamano: >> "Johannes Schindelin via GitGitGadget" >> writes: >> >>> * We now assign errno only when the call to CreateProcessW() failed. >> >> Meaning the global variable 'errno' is left as it was (instead of >> getting cleared) when a system call succeeds? That I think is the >> correct behaviour people who use the variable expect. > > I hope you mean people who read the code. You cannot possibly mean > developers who expect that the run-command API keeps errno unchanged if > the calls were successful. I'm pretty sure they do not provide such a > guarantee. POSIX guarantees that no library function sets errno to zero. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."