From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 34DCD1F5AE for ; Fri, 23 Apr 2021 23:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbhDWX3G (ORCPT ); Fri, 23 Apr 2021 19:29:06 -0400 Received: from mav.lukeshu.com ([104.207.138.63]:35928 "EHLO mav.lukeshu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232402AbhDWX3E (ORCPT ); Fri, 23 Apr 2021 19:29:04 -0400 Received: from lukeshu-dw-thinkpad (unknown [IPv6:2601:281:8200:26:4e34:88ff:fe48:5521]) by mav.lukeshu.com (Postfix) with ESMTPSA id CE1C780590; Fri, 23 Apr 2021 19:28:17 -0400 (EDT) Date: Fri, 23 Apr 2021 17:28:17 -0600 Message-ID: <8735vgbmy6.wl-lukeshu@lukeshu.com> From: Luke Shumaker To: Eric Sunshine Cc: Luke Shumaker , Git List , Avery Pennarun , Charles Bailey , Danny Lin , "David A .\ Greene" , David Aguilar , Jakub Suder , James Denholm , Jeff King , Jonathan Nieder , Junio C Hamano , =?UTF-8?B?Tmd1?= =?UTF-8?B?eeG7hW4g?= =?ISO-8859-1?Q?Th=E1i_?= =?UTF-8?B?Tmfhu41j?= Duy , Roger L Strain , Techlive Zheng , Luke Shumaker Subject: Re: [PATCH 14/30] subtree: drop support for git < 1.7 In-Reply-To: References: <20210423194230.1388945-1-lukeshu@lukeshu.com> <20210423194230.1388945-15-lukeshu@lukeshu.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, 23 Apr 2021 14:31:46 -0600, Eric Sunshine wrote: > > On Fri, Apr 23, 2021 at 3:43 PM Luke Shumaker wrote: > > That was nice to have when git-subtree lived out-of-tree. But now that > > it lives in git.git, it's not nescessary to keep around. > > s/nescessary/necessary/ Ack. > > Signed-off-by: Luke Shumaker > > Is there a higher reason for this change aside from "let's do it > because we can"? For instance, are subsequent changes going to take > advantage of features only present in more recent Git versions which > would be painful or impossible to support with the older Git? > > The downside of this change is that, while git-subtree may live in > git.git, it's still just "contrib", so people might grab git-subtree > from a modern git.git but then end up using it with an older Git > installation. That's not to say that doing such a thing is guaranteed > to work anyhow, but we don't need to make it harder on people if there > isn't a good reason (hence my question about whether subsequent > changes will actually take advantage of newer Git features). With the goal of making the whole thing easier to hack on, this just seemed like an easy (if small) piece of fat to trim. I guess I should include here that my bias is: With the 'git' package that Parabola inherits from Arch Linux, you install 'git', you get a working 'git subtree'. If you want 'git send-email' to work, you also need to install several other Perl packages. Like, it might live in the "contrib" directory, but it's de-facto at least as much a "part of" Git as send-email is. So that's the mindset I started from. It looks like the latest macOS supports me on that, but other distros like Fedora don't (Fedora has a separate 'git-subtree' package). If I take a step back, I realize that mindset is flawed, but that's where I started from. I don't think any of the other work depends on this (I think the only commit that will conflict if we drop it is the "rename a some variables" commit in this patchset). It's very possible that something else I do relies on newer git features (I'm not testing against older git), but that's not something I did intentionally. I just figured this would be a welcome piece of cleanup. If that's not the case, I don't have a problem dropping it. -- Happy hacking, ~ Luke Shumaker