From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 68F5B1F8C8 for ; Tue, 28 Sep 2021 19:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242567AbhI1TxV (ORCPT ); Tue, 28 Sep 2021 15:53:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242390AbhI1TxV (ORCPT ); Tue, 28 Sep 2021 15:53:21 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56EA3C061745 for ; Tue, 28 Sep 2021 12:51:41 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id x7so72766128edd.6 for ; Tue, 28 Sep 2021 12:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=phTbnp9386DrBgvQ/CAmCu4hAMqudlppcFOFH/TmaxE=; b=SzEukaPtX/igsFbz7X7nEtjPOlIdPQkAOlH8msZC/rfI6edsDr0OxM0zPzw8AnIG08 GyraKxc7vc/FsjgJjCtYby4ekS59mSeU2BP2h2KnCglamBlWiyPazKz8fuKjKdQMVNMV 6niu4uWSBanl+eVpWOnC5IZ5lJFXkbhowcrp9LJ4JY3AN7cSLgoY3M/HYFZV+uDgLgap 65YzvU3LFsLvHbNW5LIzh8WJD7EZNUKiA2tbRYj0rPLLPScq+DOPz/ZSf8DUHUhHb0RX 7ZpxVWYxAzBpDEFThLvt/qznn50m7sM7Jb51g8s08kdjuHHteELmAE9Akbasq4Sel83N +NIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=phTbnp9386DrBgvQ/CAmCu4hAMqudlppcFOFH/TmaxE=; b=VYEZlcZ5huUWJ+xbQFWPrL3ApW6BBmP1MZUFZd1kdhsqyJ3GLJO7oGwB0ItZo1J8jS EW1bMrqIBYto+v7c5x5E9Kmm4zSclmLyRCLybp4LdMcx6vPi+BkFmCQepJODYEqWh9j8 4q1RvAlThiXrvdj6qZqvG5ej+7iDNrrwoCDMDAag0PcmX2I/uvspwoLaPWlxsCnj8Pjp y+iN1skR28rixOGmHbe2ZDGP/S7HBY0/ejnV9rjsmOLPRSoJsdqm0IzgAmwLXQyFGffq OBqEovjEeephTWGvbe/Lli0UlB8VXrtfPiUeVZyNLQgjUHnNPK5Jay0D+idQ34KlGTDD doBg== X-Gm-Message-State: AOAM532MFMMxLn1xRTOMQeL6pv3qFz7QQUkdYH6OpozQBuRnTTVPqhbi Kj50NcUN4No+zAZvPaNlgNdi/p0ck3/2yw== X-Google-Smtp-Source: ABdhPJw38psO3P1vPL/S4g531Se+Yek9UMy9ELSPWP3N/zvEVgTrI15/u2aMHzCUbLjV2y/vPVfILw== X-Received: by 2002:a17:906:f0cc:: with SMTP id dk12mr8638742ejb.36.1632858699846; Tue, 28 Sep 2021 12:51:39 -0700 (PDT) Received: from evledraar (j120189.upc-j.chello.nl. [24.132.120.189]) by smtp.gmail.com with ESMTPSA id c11sm38611edw.5.2021.09.28.12.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 12:51:39 -0700 (PDT) From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Junio C Hamano Cc: git@vger.kernel.org, Ramsay Jones , Denton Liu , Jeff King Subject: Re: [PATCH v4] Makefile: add a non-.PHONY "sparse-incr" target Date: Tue, 28 Sep 2021 21:45:19 +0200 References: User-agent: Debian GNU/Linux bookworm/sid; Emacs 27.1; mu4e 1.7.0 In-reply-to: Message-ID: <8735powkad.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 28 2021, Junio C Hamano wrote: > =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > >> I.e. per [2] want "make .sp" to *always* run "sparse", even >> though a corresponding "make .o" would only re-run the "real" >> compilation if needed. > > It is different from my reading. If .c and what it includes > haven't changed, it would be fine not to run "sparse". I was attempting to summarize this part of Ramsay Jones's comments in=20 [...] Prior to this patch series, 'make .sp' would _always_ run sparse over the file - it would not depend on the 'mtime' or existence of any other file, or run the compiler (and wouldn't leave any 'droppings' either). I liked that! :D > The point of > running "make .sp" is to see it fail if there is something > problematic. If there is any room for the word "*always*" to come > into the observation, it would be more like "if we cannot make it > follow the usual dependency rules like the real compilation, we can > live with it always running, as it is fast enough". If we can make > it honor the dependencies, that would give the best of both worlds, > and we do not have to add an extra target. ...which I think describe something different than what you're describing here. I.e. I was under the impression that you didn't mind the incremental part of it (but Ramsey did), but just didn't want the initial "make sparse" to take much longer due to the *.o file compilation. In any case, we can always tweak the "make .sp" later. I don't mind it working the way it did before, I think the only time I ever make individual files is when generating the assembly output for them. So as long as I've got a "make sparse-incr" target I can use. Do you think that approach in this v4 is OK to move forward?