From: "Strawbridge, Michael" <Michael.Strawbridge@amd.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [Proposal] Pass additional metadata to sendemail-validate hook from git send-email
Date: Mon, 29 Aug 2022 15:37:55 +0000 [thread overview]
Message-ID: <8735dfkqlo.fsf@amd.com> (raw)
In-Reply-To: <87czcm7maf.fsf@amd.com>
Thanks for getting back to me. I'll write up a patch.
brian m. carlson writes:
> On 2022-08-26 at 21:00:25, Strawbridge, Michael wrote:
> > Hi,
>
> Hey,
>
> > I was hoping to put a feature proposal forward for git
> > send-email.
> >
> > For git send-email there is a git hook, sendemail-validate
> > which
> > gets the body of the email that will be sent but is missing
> > some
> > of the metadata that git send-email has access to. I propose
> > that
> > we also pass the extra metadata that gets presented to the
> > user
> > later on via stdout such as: From, To, Cc, Subject, Date,
> > Message-Id, X-Mailer, MIME-Version, Content-Transfer-Encoding
> > to
> > the git hook.
> >
> > I'm willing to work on the patch but want to make sure the
> > idea
> > would be accepted first.
>
> I think the idea is interesting and would be willing to see a
> patch come
> to the list.
>
> However, having said that, we typically evaluate patches, not
> proposals,
> so to see if it's actually accepted, you'd have to actually send
> a
> patch. We may find that while the idea is interesting, it turns
> out to
> be infeasible, or, for whatever reason, the patch is unsuitable.
>
> I know that this is different from how other projects typically
> work,
> where you typically pitch an idea first and then implement, but
> it's
> what we do here.
> --
> brian m. carlson (he/him or they/them)
> Toronto, Ontario, CA
prev parent reply other threads:[~2022-08-29 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 21:00 [Proposal] Pass additional metadata to sendemail-validate hook from git send-email Strawbridge, Michael
2022-08-28 0:39 ` [Proposal] Pass additional metadata to sendemail-validate hook from git send-emailg brian m. carlson
2022-08-29 15:37 ` Strawbridge, Michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735dfkqlo.fsf@amd.com \
--to=michael.strawbridge@amd.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).