From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS53758 23.128.96.0/24
X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS,
	SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id 6C2AC1F5AE
	for <e@yhbt.net>; Fri, 23 Apr 2021 23:38:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S244252AbhDWXis (ORCPT <rfc822;e@yhbt.net>);
        Fri, 23 Apr 2021 19:38:48 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S244174AbhDWXht (ORCPT <rfc822;git@vger.kernel.org>);
        Fri, 23 Apr 2021 19:37:49 -0400
Received: from mav.lukeshu.com (mav.lukeshu.com [IPv6:2001:19f0:5c00:8069:5400:ff:fe26:6a86])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DBD6C06175F
        for <git@vger.kernel.org>; Fri, 23 Apr 2021 16:37:12 -0700 (PDT)
Received: from lukeshu-dw-thinkpad (unknown [IPv6:2601:281:8200:26:4e34:88ff:fe48:5521])
        by mav.lukeshu.com (Postfix) with ESMTPSA id 0A26280591;
        Fri, 23 Apr 2021 19:37:10 -0400 (EDT)
Date:   Fri, 23 Apr 2021 17:37:10 -0600
Message-ID: <871rb0bmjd.wl-lukeshu@lukeshu.com>
From:   Luke Shumaker <lukeshu@lukeshu.com>
To:     Eric Sunshine <sunshine@sunshineco.com>
Cc:     Luke Shumaker <lukeshu@lukeshu.com>,
        Git List <git@vger.kernel.org>,
        Avery Pennarun <apenwarr@gmail.com>,
        Charles Bailey <cbailey32@bloomberg.net>,
        Danny Lin <danny0838@gmail.com>,
        "David A . Greene" <greened@obbligato.org>,
        David Aguilar <davvid@gmail.com>,
        Jakub Suder <jakub.suder@gmail.com>,
        James Denholm <nod.helm@gmail.com>, Jeff King <peff@peff.net>,
        Jonathan Nieder <jrnieder@gmail.com>,
        Junio C Hamano <gitster@pobox.com>,
        =?UTF-8?B?Tmd1?= =?UTF-8?B?eeG7hW4g?= =?ISO-8859-1?Q?Th=E1i_?=
         =?UTF-8?B?Tmfhu41j?= Duy <pclouds@gmail.com>,
        Roger L Strain <roger.strain@swri.org>,
        Techlive Zheng <techlivezheng@gmail.com>,
        Luke Shumaker <lukeshu@datawire.io>
Subject: Re: [PATCH 12/30] subtree: don't have loose code outside of a function
In-Reply-To: <CAPig+cTnqYnxPpcn1GTDOpzb2mHAseA694cc-d3mP0JD7VNU5A@mail.gmail.com>
References: <20210423194230.1388945-1-lukeshu@lukeshu.com>
        <20210423194230.1388945-13-lukeshu@lukeshu.com>
        <CAPig+cQLP1XFnMFWOp4Zj-Ku8M-aqgE5DmpgEy=UWLqpBBW8Ng@mail.gmail.com>
        <87tunw1v1l.wl-lukeshu@lukeshu.com>
        <CAPig+cTnqYnxPpcn1GTDOpzb2mHAseA694cc-d3mP0JD7VNU5A@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

On Fri, 23 Apr 2021 17:11:11 -0600,
Eric Sunshine wrote:
> If you happen to re-roll, perhaps update the commit message to include
> a small bit of your explanation (which I've mostly snipped here). The
> last bit about moving `set -- -h` and whatnot closer to the rest of
> the argument parsing -- basically improving encapsulation -- may be
> justification enough for readers.

Whenever I end up explaining something on-list, I assume that I should
update either a comment or a commit-message when I re-roll :)

-- 
Happy hacking,
~ Luke Shumaker