git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: merlyn@stonehenge.com (Randal L. Schwartz)
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] perl shebangs: Use /usr/bin/env, not /usr/bin/perl
Date: Fri, 21 May 2010 08:32:53 -0700	[thread overview]
Message-ID: <86tyq1gti2.fsf@red.stonehenge.com> (raw)
In-Reply-To: <1274454086-2312-1-git-send-email-avarab@gmail.com> ("Ævar	Arnfjörð Bjarmason"'s message of "Fri, 21 May 2010 15:01:26 +0000")

>>>>> "Ævar" == Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Ævar> Change the Perl Git utilities to use #!/usr/bin/env perl as a shebang
Ævar> instead of #!/usr/bin/perl. This makes e.g. git-send-email work if
Ævar> your personal perl has Net::SMTP::SSL, but your system perl
Ævar> doesn't.

Not a good idea in general.

Ævar> With this change all the code in Git that uses a shebang now uses
Ævar> /usr/bin/env, except those things that use /bin/sh and /bin/bash. All
Ævar> the Python code already used it, and some of the Perl code.

Sorry I didn't catch this earlier then.

I often have an "experimental" Perl earlier in my path than the
"official" Perl.  This would mean that I'd get different behaviors
running git from the command line than I would from automated tools, and
it would be relatively confusing.

The official Perl should be in /usr/bin or /usr/local/bin, and that's
the one you should use with Git.  *Or*, give the installer a knob to
configure.

But please don't use env.  Heck, some systems might not even *have*
env.  And some systems have it in /bin and not /usr/bin.  Don't ruin
portablity at this point, please.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion

  parent reply	other threads:[~2010-05-21 15:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 14:50 [PATCH] perl libs: perl -w + use warnings is redundant Ævar Arnfjörð Bjarmason
2010-05-21 15:01 ` [PATCH] perl shebangs: Use /usr/bin/env, not /usr/bin/perl Ævar Arnfjörð Bjarmason
2010-05-21 15:15   ` Peter Kjellerstedt
2010-05-21 15:22     ` Ævar Arnfjörð Bjarmason
2010-05-21 16:54       ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-05-21 15:26     ` [PATCH] " Tor Arntsen
2010-05-21 15:32   ` Randal L. Schwartz [this message]
2010-05-21 16:01     ` Jeff King
2010-05-21 16:52 ` [PATCH 1/2] perl libs: perl -w + use warnings is redundant Ævar Arnfjörð Bjarmason
2010-05-21 16:55   ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tyq1gti2.fsf@red.stonehenge.com \
    --to=merlyn@stonehenge.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).