From: David Kastrup <dak@gnu.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 4/5] Full rework of quote_c_style and write_name_quoted.
Date: Wed, 19 Sep 2007 10:28:03 +0200 [thread overview]
Message-ID: <86r6kv2h64.fsf@lola.quinscape.zz> (raw)
In-Reply-To: 20070919082111.GB28205@artemis.corp
Pierre Habouzit <madcoder@debian.org> writes:
> On Wed, Sep 19, 2007 at 08:08:02AM +0000, Andreas Ericsson wrote:
>> Then perhaps a separate patch for this would have been prudent? I'm not
>> against the change per se and I understand the reasoning behind it, but
>> it seems to go against Documentation/SubmittingPatches (submit one change
>> at a time).
>
> Yes, the thing is, I wrote it in one piece, and had a _very_ hard time
> splitting it. The aggregated patches had almost no chunks, and editing
> diffs by hand isn't what I like to do :)
Use Emacs for it. After loading the patch in a file, type
Esc x diff-mode RET
If you now move to a place in the middle of a hunk and type C-c C-s,
the hunk is split at that point into two hunks. C-c C-k kills the
current hunk. C-x C-s saves the file, C-x C-c exits Emacs.
In that manner throwing selected material out of a patch is rather
straightforward, even when it is in the middle of a hunk.
--
David Kastrup
next prev parent reply other threads:[~2007-09-19 8:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 22:39 let's refactor quoting Pierre Habouzit
2007-09-18 17:18 ` [PATCH 1/5] strbuf API additions and enhancements Pierre Habouzit
2007-09-19 12:46 ` Edgar Toernig
2007-09-19 13:36 ` Pierre Habouzit
2007-09-19 18:46 ` Junio C Hamano
2007-09-20 6:17 ` Johannes Sixt
2007-09-20 7:20 ` Kalle Olavi Niemitalo
2007-09-20 16:10 ` Jeff King
2007-09-18 20:15 ` [PATCH 2/5] sq_quote_argv and add_to_string rework with strbuf's Pierre Habouzit
2007-09-19 8:09 ` Junio C Hamano
2007-09-19 8:23 ` Pierre Habouzit
2007-09-18 21:22 ` [PATCH 3/5] Rework unquote_c_style to work on a strbuf Pierre Habouzit
2007-09-19 0:14 ` Pierre Habouzit
2007-09-19 8:09 ` Junio C Hamano
2007-09-19 8:22 ` Pierre Habouzit
2007-09-18 21:48 ` [PATCH 5/5] Avoid duplicating memory, and use xmemdupz instead of xstrdup Pierre Habouzit
2007-09-18 22:00 ` [PATCH 4/5] Full rework of quote_c_style and write_name_quoted Pierre Habouzit
2007-09-19 0:07 ` Pierre Habouzit
2007-09-19 0:55 ` Junio C Hamano
2007-09-19 1:14 ` Pierre Habouzit
2007-09-19 6:37 ` Andreas Ericsson
2007-09-19 8:00 ` Pierre Habouzit
2007-09-19 8:08 ` Andreas Ericsson
2007-09-19 8:21 ` Pierre Habouzit
2007-09-19 8:28 ` David Kastrup [this message]
2007-09-19 8:31 ` Junio C Hamano
2007-09-19 8:38 ` David Kastrup
2007-09-19 8:28 ` Junio C Hamano
2007-09-19 8:47 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r6kv2h64.fsf@lola.quinscape.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).