list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jakub Narebski <>
To: "Giuseppe Crinò" <>
Cc: "Junio C Hamano" <>,
	"Ævar Arnfjörð Bjarmason" <>,
Subject: Re: Feature request: Allow to update commit ID in messages when rebasing
Date: Fri, 19 Apr 2019 12:44:20 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> ("Giuseppe \=\?utf-8\?Q\?Crin\=C3\=B2\=22's\?\= message of "Thu, 18 Apr 2019 19:58:23 +0200")


Giuseppe Crinò <> writes:
> On Thu, Apr 18, 2019 at 7:32 PM Jakub Narebski <> wrote:

>> Well, what about limiting changes and rewriting only to the commits
>> being rewritten by [interactive] rebase?  I mean that we would rewrite
>> "revert 01a9fe8" only if:
>> a.) the commit with this message is undergoing rewrite
>> b.) the commit 01a9fe8 is undergoing rewrite in the same command
>> We could use the infrastructure from git-filter-branch for this.
>> It is serious limitation, but that might be good enough for Giuseppe
>> Crinò use case.
> In which case you need to change the ID of "revert 01a9fe8" _even if_
> 01a9fe8 is not involved in the rebase? Wouldn't be a solution to my
> use-case an already complete solution?

What I meant by "serious limitation" is that the condition a.) might mot
hold true.  You might be rebasing / rewriting the commit 01a9fe8, but
there might be some commit not undergoing rewrite (for example one on a
separate branch) that refers to the commit being rewritten, e.g. by
including "revert 01a9fe8" in the commit message.

We also need to assume that the commit referred to (i.e. 01a9fe8) is
being rewritten earlier in sequence than referring commit (i.e. one with
"revert 01a9fe8").

Jakub Narębski

  reply	other threads:[~2019-04-19 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 20:35 Giuseppe Crinò
2019-04-17 20:56 ` Ævar Arnfjörð Bjarmason
2019-04-18  2:08   ` Junio C Hamano
2019-04-18 17:32     ` Jakub Narebski
2019-04-18 17:58       ` Giuseppe Crinò
2019-04-19 10:44         ` Jakub Narebski [this message]
2019-04-18 18:00       ` Phil Hord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).