From: Matthieu Moy <git@matthieu-moy.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Michael Haggerty" <mhagger@alum.mit.edu>,
"Ville Skyttä" <ville.skytta@iki.fi>,
"Luke Diamand" <luke@diamand.org>,
"Lars Schneider" <larsxschneider@gmail.com>,
git@vger.kernel.org
Subject: Re: multimail/p4: issues identified by lgtm.com
Date: Mon, 19 Mar 2018 14:50:43 +0100 [thread overview]
Message-ID: <86d100uqbw.fsf@matthieu-moy.fr> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1803191217410.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
Johannes Schindelin writes:
> Hi team,
>
> while Coverity was down (it still is not reachable for me, but I guess
> that's just because everybody and their dog wants to catch up on a month
> of work delayed by their outage), I tried to find alternatives, and one of
> them is lgtm.com. Their C/C++ support is not generally available yet, but
> there have been a couple of issues identified in our Python scripts:
>
> https://lgtm.com/projects/g/git/git/alerts/?mode=list&rule=py%2Fcall%2Fwrong-arguments%2Cpy%2Fcall%2Fwrong-named-argument%2Cpy%2Fexplicit-call-to-delete%2Cpy%2Finconsistent-equality%2Cpy%2Finheritance%2Fincorrect-overridden-signature%2Cpy%2Fmissing-call-to-init%2Cpy%2Fmultiple-definition%2Cpy%2Fredundant-else%2Cpy%2Funinitialized-local-variable%2Cpy%2Funreachable-statement
>
> From a cursory look, it *does* seem as if there are legitimate issues
> there that want to be fixed ;-) But then, I am far from a Python expert,
> so my impressions could be completely off the mark.
For git-multimail, there are actually a lot of false-positive due to the
way we use multiple-inheritance (when calling super(...).__init__(),
lgtm assumes we're calling the superclass's constructor while we
actually call the "next in the method resolution order list"), but also
probably valid concerns.
I've set up a separate project for git-multimail:
https://lgtm.com/projects/g/git-multimail/git-multimail/alerts/?mode=list
I'll have a deeper look ASAP.
Thanks!
--
Matthieu Moy
https://matthieu-moy.fr/
prev parent reply other threads:[~2018-03-19 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 11:24 multimail/p4: issues identified by lgtm.com Johannes Schindelin
2018-03-19 13:50 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d100uqbw.fsf@matthieu-moy.fr \
--to=git@matthieu-moy.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
--cc=mhagger@alum.mit.edu \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).