git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: What's cooking in git.git (Apr 2022, #03; Tue, 12)
Date: Tue, 12 Apr 2022 13:52:16 -0400	[thread overview]
Message-ID: <8698e468-5552-77a3-10c7-933affd98832@gmail.com> (raw)
In-Reply-To: <xmqq8rsab5do.fsf@gitster.g>

Hi Junio,

Le 2022-04-12 à 13:04, Junio C Hamano a écrit :
> 
> 
> Security releases for the 2.30-2.35 maintenance tracks have been
> tagged to address CVE-2022-24765, which allows a user to trick other
> users into running a command of their choice easily on multi-user
> machines with a shared "mob" directory.  The fix has been also
> merged to Git 2.36-rc2 and to all integration branches.
> 

This is quite a big behaviour change for some environments [1], so I would think maybe it
deserves to be fully spelled out in the release notes for 2.36.0,
instead of just referring readers to the release notes for the maintenance
release, where they can read a full description only in the release notes
for 2.30.3 ?

Thanks,
Philippe.

[1] the commit message for the change mentions "shared directories", 
but in some environments, it is quite common for each user to have
read access to other uers's home directories. I'm mostly thinking about
high performance computing clusters, which is the kind of systems I have 
experience with. This makes it really easy for local
"git experts" to 'cd' into a colleague's repo and help them when they 
are facing a Git problem. The fact that it won't be possible to do that
without manually invoking 'git config --add safe.directory $PWD' beforehand
is a little sad... What were the arguments for specifically disabling
'git -c safe.directory' for this fix ?

  reply	other threads:[~2022-04-12 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 17:04 What's cooking in git.git (Apr 2022, #03; Tue, 12) Junio C Hamano
2022-04-12 17:52 ` Philippe Blain [this message]
2022-04-12 18:55   ` CVE-2022-24765 and core.sharedRepository (was: What's cooking in git.git (Apr 2022, #03; Tue, 12)) Ævar Arnfjörð Bjarmason
2022-04-13  3:10     ` demerphq
2022-04-13 23:51   ` What's cooking in git.git (Apr 2022, #03; Tue, 12) Junio C Hamano
2022-04-13 20:08 ` ab/plug-leak-in-revisions (was: What's cooking in git.git (Apr 2022, #03; Tue, 12)) Ævar Arnfjörð Bjarmason
2022-04-13 23:32   ` ab/plug-leak-in-revisions Junio C Hamano
2022-04-14  7:22     ` ab/plug-leak-in-revisions Ævar Arnfjörð Bjarmason
2022-04-14 18:33       ` ab/plug-leak-in-revisions Junio C Hamano
2022-04-13 20:11 ` ab/ci-setup-simplify etc. (was: What's cooking in git.git (Apr 2022, #03; Tue, 12)) Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8698e468-5552-77a3-10c7-933affd98832@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).