From: "Łukasz Niemier" <lukasz@niemier.pl>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] userdiff: add Elixir to supported userdiff languages
Date: Fri, 8 Nov 2019 16:42:00 +0100 [thread overview]
Message-ID: <86417D50-2C28-477A-BC49-9097A24A3BF3@niemier.pl> (raw)
In-Reply-To: <f85a5c31-52ff-85be-b1e0-f3982fd2a7f2@kdbg.org>
> Please keep the Cc list when you send new patch versions. Also, it is
> customary to send them as replies to the earlier iterations, so that
> they all end up in the same thread.
Sorry, I am still learning how to use git send-email and I thought it would be handled automatically.
I need to find how to operate it properly and how to configure it to reply in thread instead of
creating new one.
> There are no single- and double-quote anymore. An oversight? Or an error
> in the earlier iteration?
No, I intentionally left them out, as :’foo bar’ is allowed atom, and I didn’t want to complicate
everything word regex. Instead I assumed that these are so rare, that it should not be a problem.
> The leading optional sign may be problematic. When a patch changes "i+1"
> to "i+2", it would be highlighted as "i{-+1-}{++2+}" instead of as
> "i+{-1-}{+2+}". You could remove the leading optional sign and let it be
> processed as an operator. But we also have an optional sign in the cpp
> pattern as well, and haven't noticed it until now, so…
I copied this pattern from other languages, so I assumed that this is what is expected.
It could be fixed, but I think it should be handled in separate patch.
--
Łukasz Niemier
lukasz@niemier.pl
next prev parent reply other threads:[~2019-11-08 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 23:49 [PATCH v3] userdiff: add Elixir to supported userdiff languages Łukasz Niemier
2019-11-07 20:35 ` Johannes Sixt
2019-11-08 15:42 ` Łukasz Niemier [this message]
2019-11-08 21:38 ` [PATCH v4] " Łukasz Niemier
2019-11-09 19:31 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86417D50-2C28-477A-BC49-9097A24A3BF3@niemier.pl \
--to=lukasz@niemier.pl \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).