git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] basic threaded delta search
Date: Thu, 06 Sep 2007 08:19:42 +0200	[thread overview]
Message-ID: <85ps0wfh8h.fsf@lola.goethe.zz> (raw)
In-Reply-To: <1189059193250-git-send-email-nico@cam.org> (Nicolas Pitre's message of "Thu\, 06 Sep 2007 02\:13\:11 -0400")

Nicolas Pitre <nico@cam.org> writes:

> this is still rough, hence it is disabled by default.  You need to compile
> with "make THREADED_DELTA_SEARCH=1 ..." at the moment.
>
> Threading is done on different portions of the object list to be
> deltified. This is currently done by spliting the list into n parts and
> then a thread is spawned for each of them.  A better method would consist
> of spliting the list into more smaller parts and have the n threads
> pick the next part available.

In my experience, the worst performance hit happens when the real
memory is exhausted and things start paging.  Threading on different
portions of the object list is going to exacerbate the problem in the
areas where it hits worst.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2007-09-06  6:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06  6:13 [PATCH] straighten the list of objects to deltify Nicolas Pitre
2007-09-06  6:13 ` [PATCH] localize window memory usage accounting Nicolas Pitre
2007-09-06  6:13   ` [PATCH] rearrange delta search progress reporting Nicolas Pitre
2007-09-06  6:13     ` [PATCH] basic threaded delta search Nicolas Pitre
2007-09-06  6:19       ` David Kastrup [this message]
2007-09-06  6:23         ` Nicolas Pitre
2007-09-06  7:01       ` Junio C Hamano
2007-09-06 14:48         ` Nicolas Pitre
2007-09-07  6:11           ` Martin Koegler
2007-09-07 16:19             ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ps0wfh8h.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).