From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
jnareb@gmail.com
Subject: Re: What's cooking in git.git (Aug 2018, #03; Wed, 15)
Date: Thu, 16 Aug 2018 09:15:34 -0400 [thread overview]
Message-ID: <85c6eb4c-a083-4fb7-4860-b01a8ce9fa4f@gmail.com> (raw)
In-Reply-To: <xmqqpnyjgroj.fsf@gitster-ct.c.googlers.com>
On 8/15/2018 7:01 PM, Junio C Hamano wrote:
> * ds/commit-graph-with-grafts (2018-07-19) 8 commits
> (merged to 'next' on 2018-08-02 at 0ee624e329)
> + commit-graph: close_commit_graph before shallow walk
> + commit-graph: not compatible with uninitialized repo
> + commit-graph: not compatible with grafts
> + commit-graph: not compatible with replace objects
> + test-repository: properly init repo
> + commit-graph: update design document
> + refs.c: upgrade for_each_replace_ref to be a each_repo_ref_fn callback
> + refs.c: migrate internal ref iteration to pass thru repository argument
>
> The recently introduced commit-graph auxiliary data is incompatible
> with mechanisms such as replace & grafts that "breaks" immutable
> nature of the object reference relationship. Disable optimizations
> based on its use (and updating existing commit-graph) when these
> incompatible features are in use in the repository.
>
> Perhaps eject and replace with another reroll when it comes.
> cf. <a3640919-95cf-cca4-d552-4715a031dd7f@gmail.com>
> cf. <86bmap7l7a.fsf@gmail.com>
Yes, I am working on a re-roll. Feel free to eject in the meantime.
For one, I need to base it on jk/core-use-replace-refs. This is not
hard, as it is already in master.
For two, I was waiting for resolution on the way to handle arbitrary
repositories in for_each_replace_ref. Stefan had a few proposed patches,
but they don't seem to have completed. Can someone fill me in on the
status there? I could re-roll with the two simple patches that I have,
which send the struct repository pointer into the 'void *' data parameter.
Finally, I have some non-trivial feedback from Jakub to work on.
Thanks,
-Stolee
next prev parent reply other threads:[~2018-08-16 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 23:01 What's cooking in git.git (Aug 2018, #03; Wed, 15) Junio C Hamano
2018-08-16 2:35 ` Stefan Beller
2018-08-16 14:58 ` Junio C Hamano
2018-08-16 13:15 ` Derrick Stolee [this message]
2018-08-16 14:43 ` Stefan Beller
2018-08-17 14:56 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85c6eb4c-a083-4fb7-4860-b01a8ce9fa4f@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).