git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Thomas Uhle <thomas.uhle@mailbox.tu-dresden.de>
To: <git@vger.kernel.org>
Subject: [PATCH] contrib/credential: add install target
Date: Sat, 25 Oct 2025 22:15:12 +0200	[thread overview]
Message-ID: <84d7c984-b594-3ac7-2593-58664bd8c726@mailbox.tu-dresden.de> (raw)

Add an install target rule to the Makefiles in contrib/credential in the
same manner as in other Makefiles in contrib such as for contacts or
subtree.
---
This is the follow-up commit on top of some clean-up changes to the
Makefiles in contrib/credential that I have been asked to send as a
separate patch.  Here is the previous patch:
https://lore.kernel.org/git/0a61b0b3-365b-c198-6afd-f26fcd5a9c20@mailbox.tu-dresden.de/

 contrib/credential/libsecret/Makefile   | 7 ++++++-
 contrib/credential/osxkeychain/Makefile | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/contrib/credential/libsecret/Makefile b/contrib/credential/libsecret/Makefile
index 7cacc57..b10cfa3 100644
--- a/contrib/credential/libsecret/Makefile
+++ b/contrib/credential/libsecret/Makefile
@@ -10,6 +10,7 @@
 CC ?= gcc
 CFLAGS ?= -g -O2 -Wall
 PKG_CONFIG ?= pkg-config
+INSTALL ?= install
 RM ?= rm -f

 INCS:=$(shell $(PKG_CONFIG) --cflags libsecret-1 glib-2.0)
@@ -21,7 +22,11 @@
 git-credential-libsecret: git-credential-libsecret.o
 	$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(LIBS)

+install: git-credential-libsecret
+	$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)
+	$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)
+
 clean:
 	$(RM) git-credential-libsecret git-credential-libsecret.o

-.PHONY: all clean
+.PHONY: all install clean
diff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile
index c7d9121..5569581 100644
--- a/contrib/credential/osxkeychain/Makefile
+++ b/contrib/credential/osxkeychain/Makefile
@@ -9,6 +9,7 @@

 CC ?= gcc
 CFLAGS ?= -g -O2 -Wall
+INSTALL ?= install
 RM ?= rm -f

 %.o: %.c
@@ -18,7 +19,11 @@
 	$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) \
 		-framework Security -framework CoreFoundation

+install: git-credential-osxkeychain
+	$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)
+	$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)
+
 clean:
 	$(RM) git-credential-osxkeychain git-credential-osxkeychain.o

-.PHONY: all clean
+.PHONY: all install clean

base-commit: 4e98b730f18d59b670ee57b803e5048b9d14b968
-- 
2.47.3


             reply	other threads:[~2025-10-25 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-25 20:15 Thomas Uhle [this message]
2025-10-25 20:30 ` [PATCH v2] contrib/credential: add install target Thomas Uhle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84d7c984-b594-3ac7-2593-58664bd8c726@mailbox.tu-dresden.de \
    --to=thomas.uhle@mailbox.tu-dresden.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).