From: Lars Schneider <larsxschneider@gmail.com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Lars Schneider <lars.schneider@autodesk.com>,
git@vger.kernel.org, sbeller@google.com, sunshine@sunshineco.com,
sandals@crustytoothpaste.net, peff@peff.net
Subject: Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input
Date: Thu, 7 Dec 2017 18:56:59 +0100 [thread overview]
Message-ID: <84C88A13-FB21-425A-BEB2-C9041848CA67@gmail.com> (raw)
In-Reply-To: <dfb2cde5-a499-8da3-9695-8c8fd46a96ad@gmail.com>
> On 07 Dec 2017, at 18:37, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:
>
> On Thursday 07 December 2017 10:00 PM, Junio C Hamano wrote:
>> +
>> + if (print_waiting_for_editor) {
>> + /*
>> + * A dumb terminal cannot erase the line later on. Add a
>> + * newline to separate the hint from subsequent output.
>> + *
>
>
>> + * In case the editor emits further cruft after what
>> + * we wrote above, separate it from our message with SP.
>
> I guess this part of the comment could be improved a little. I currently interpret it as "See if the editor emits further cruft, print a space in that case". Though, it's not what we are doing. Something like the following, perhaps?
>
> In a non-dumb terminal, separate our message from further cruft
> that might be emitted by the editor with SP.
I see what you mean. My (non-native) language feeling tells me that
reordering the sentence might sound better:
* In a non-dumb terminal, separate our message with SP
* from further cruft that might be emitted by the editor.
@Junio: If you agree with the change, can you squash either of the new versions?
Thanks,
Lars
prev parent reply other threads:[~2017-12-07 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 15:16 [PATCH v5 0/2] launch_editor(): indicate that Git waits for user input lars.schneider
2017-12-07 15:16 ` [PATCH v5 1/2] refactor "dumb" terminal determination lars.schneider
2017-12-07 15:16 ` [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input lars.schneider
2017-12-07 15:43 ` Junio C Hamano
2017-12-07 15:48 ` Lars Schneider
2017-12-07 16:16 ` Lars Schneider
2017-12-07 16:30 ` Junio C Hamano
2017-12-07 16:36 ` Lars Schneider
2017-12-07 17:37 ` Kaartic Sivaraam
2017-12-07 17:56 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84C88A13-FB21-425A-BEB2-C9041848CA67@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=lars.schneider@autodesk.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).