git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Indenting lines starting with "die" in shell after "||"
Date: Mon, 27 Jul 2015 12:25:35 +0200	[thread overview]
Message-ID: <847c822062707efaf2171b5568e00e45@www.dscho.org> (raw)
In-Reply-To: <CAP8UFD3UmrmREa8hN=jGNM8FMc3XHOyX9hGjfRDej_qMrNsaXw@mail.gmail.com>

Hi Christian,

On 2015-07-27 11:20, Christian Couder wrote:

> It looks like we are very inconsistent in shell scripts about
> indenting lines starting with "die" after a line that ends with "||",
> like:
> 
> quite long command ||
> die "command failed"
> 
> For example in git-rebase--interactive.sh, there is often, but not
> always, an extra tab before the die.

That is most likely my fault: I used to add that extra tab. It appears to me as if the convention in Git (and in my current coding style) is not to add an extra tab.

Ciao,
Dscho

      reply	other threads:[~2015-07-27 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  9:20 Indenting lines starting with "die" in shell after "||" Christian Couder
2015-07-27 10:25 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=847c822062707efaf2171b5568e00e45@www.dscho.org \
    --to=johannes.schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).