From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol
Date: Mon, 29 May 2017 13:11:55 +0200 [thread overview]
Message-ID: <832A4D04-F32F-4D1F-A5CE-3514F8469E63@gmail.com> (raw)
In-Reply-To: <DB31E695-B7D5-4337-BACD-5191EB642F40@gmail.com>
> On 23 May 2017, at 10:43, Lars Schneider <larsxschneider@gmail.com> wrote:
>
>
>> On 23 May 2017, at 07:22, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>>>> + sigchain_pop(SIGPIPE);
>>>>> +
>>>>> + if (err || errno == EPIPE) {
>>>>
>>>> This looks strange, at first glance.
>>>> Do we set errno to 0 before ?
>>>> Or is there a trick that EPIPE can only be reached,
>>>> if it is "our" error ?
>>>
>>> You are right and I'll fix it!
>>> Thanks for reminding me!
>>> Peff also noticed that some time ago:
>>> http://public-inbox.org/git/20170411200520.oivytvlzkdu7bfh5@sigill.intra.peff.net/
>>
>> Ben Peart's bp/sub-process-convert-filter topic also had the same
>> EPIPE issues in its earlier incarnation, IIRC. I haven't looked at
>> this topic for some time, but I wonder if we can share code with it.
>
> That's right. There might be some code sharing opportunity with Ben's
> code that is already in "next":
> https://github.com/git/git/blob/next/convert.c#L660-L677
>
> Would it be useful for you if I send v5 with the changes rebased
> onto "next"?
Hi Junio,
sorry for bugging you again, but Ben's topic did not make it to "master"
today. Is it OK if I rebase my topic onto "next" and resend?
Thanks,
Lars
next prev parent reply other threads:[~2017-05-29 11:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:49 [PATCH v4 0/4] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-05-22 13:49 ` [PATCH v4 1/4] t0021: keep filter log files on comparison Lars Schneider
2017-05-22 13:49 ` [PATCH v4 2/4] t0021: make debug log file name configurable Lars Schneider
2017-05-22 13:50 ` [PATCH v4 3/4] t0021: write "OUT" only on success Lars Schneider
2017-05-22 13:50 ` [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-05-22 19:30 ` Taylor Blau
2017-05-22 19:52 ` Torsten Bögershausen
2017-05-22 20:33 ` Lars Schneider
2017-05-22 19:58 ` Torsten Bögershausen
2017-05-22 20:37 ` Lars Schneider
2017-05-23 5:22 ` Junio C Hamano
2017-05-23 8:43 ` Lars Schneider
2017-05-29 11:11 ` Lars Schneider [this message]
2017-05-30 1:03 ` Junio C Hamano
2017-05-30 1:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832A4D04-F32F-4D1F-A5CE-3514F8469E63@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).