From: Keith Smiley <k@keith.so>
To: Todd Zullinger <tmz@pobox.com>
Cc: Sergey Zolotarev <szolot4rev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add support for 'git remote rm' in Bash completion script
Date: Sat, 9 Feb 2019 08:47:46 -0800 [thread overview]
Message-ID: <831E8C20-CCB9-4E99-9FFD-DA7CCF825C3D@keith.so> (raw)
In-Reply-To: <20190209062706.GF30548@zaya.teonanacatl.net>
It would be great if we could land this. Non of the other solutions since I proposed my patch have happened, so in the meantime this would be nice to have.
--
Keith Smiley
> On Feb 8, 2019, at 22:27, Todd Zullinger <tmz@pobox.com> wrote:
>
> Hi Sergey,
>
> There was a previous discussion of this in December 2017,
> which might be useful:
>
> https://public-inbox.org/git/01020160a0004473-277c3d7c-4e3b-4c50-9d44-4a106f37f1d9-000000@eu-west-1.amazonses.com/
>
> It didn't end with a patch applied, but it's likely worth
> reading to help you make a case for a similar patch.
>
> One of the points in that thread is that the rm subcommand
> is not shown in completion intentionally, as the preferred
> subcommand is remove. But it should be possible to offer
> completion of the remotes after a user types rm, which I
> imagine is the more helpful part of the completion.
>
> Also, you'll want to add a signoff to the patch if/when you
> resend it (refer to Documentation/SubmittingPatches, if you
> haven't already).
>
> Sergey Zolotarev wrote:
>> ---
>> contrib/completion/git-completion.bash | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 499e56f83d..fa25d689e2 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2334,7 +2334,7 @@ _git_remote ()
>> {
>> local subcommands="
>> add rename remove set-head set-branches
>> - get-url set-url show prune update
>> + get-url set-url show prune rm update
>> "
>> local subcommand="$(__git_find_on_cmdline "$subcommands")"
>
> So instead of this change you could adjust the subcommand
> line, something like:
>
> - local subcommand="$(__git_find_on_cmdline "$subcommands")"
> + # Don't advertise rm by including it in subcommands, but complete
> + # remotes if it is used.
> + local subcommand="$(__git_find_on_cmdline "$subcommands rm")"
>
> I haven't test that, but the code looks like it hasn't
> changed since the last time we talked about this -- when I
> did test the suggestion :).
>
>> if [ -z "$subcommand" ]; then
>> @@ -2379,6 +2379,9 @@ _git_remote ()
>> prune,--*)
>> __gitcomp_builtin remote_prune
>> ;;
>> + rm,--*)
>> + __gitcomp_builtin remote_rm
>> + ;;
>> *)
>> __gitcomp_nl "$(__git_remotes)"
>> ;;
>
> I don't think you need this chunk, do you? I think that's
> only useful for completing options to the subcommand, which
> 'git remote rm' lacks.
>
> I believe you can simply skip it and let the case fall
> through to the last item which simply completes the
> available remotes, just as 'git remote remove' does.
>
> Hope that helps,
>
> --
> Todd
next prev parent reply other threads:[~2019-02-09 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 5:24 [PATCH] Add support for 'git remote rm' in Bash completion script Sergey Zolotarev
2019-02-09 6:27 ` Todd Zullinger
2019-02-09 16:47 ` Keith Smiley [this message]
2019-02-10 5:58 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831E8C20-CCB9-4E99-9FFD-DA7CCF825C3D@keith.so \
--to=k@keith.so \
--cc=git@vger.kernel.org \
--cc=szolot4rev@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).