git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>, <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
Date: Sun, 30 Jul 2017 15:49:21 +0100	[thread overview]
Message-ID: <8256C530C7DE43D7BC72BFB327DF4726@PhilipOakley> (raw)
In-Reply-To: 20170730110921.11805-1-kaarticsivaraam91196@gmail.com

From: "Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>

minor nit: It's nice, for these single character changes, to give a clue in 
the commit message as to what to look for.

E.g.

Quote the command, and remove duplicated space character

--
Philip.

> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
> Documentation/SubmittingPatches | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches 
> b/Documentation/SubmittingPatches
> index 558d465b6..9d0dab08d 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -293,7 +293,7 @@ then you just add a line saying
>
>         Signed-off-by: Random J Developer <random@developer.example.org>
>
> -This line can be automatically added by Git if you run the git-commit
> +This line can be automatically added by Git if you run the 'git commit'
> command with the -s option.
>
> Notice that you can place your own Signed-off-by: line when
> @@ -366,7 +366,7 @@ suggests to the contributors:
>      spend their time to improve your patch.  Go back to step (2).
>
>  (4) The list forms consensus that the last round of your patch is
> -     good.  Send it to the maintainer and cc the list.
> +     good. Send it to the maintainer and cc the list.
>
>  (5) A topic branch is created with the patch and is merged to 'next',
>      and cooked further and eventually graduates to 'master'.
> -- 
> 2.14.0.rc1.434.g6eded367a
> 


  parent reply	other threads:[~2017-07-30 14:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30 11:09 [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-07-30 11:09 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-07-30 14:49 ` Philip Oakley [this message]
2017-07-30 16:17   ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-07-30 16:18   ` Kaartic Sivaraam
2017-07-31 20:23     ` Stefan Beller
2017-07-31 20:34       ` Junio C Hamano
2017-08-01 15:59       ` Kaartic Sivaraam
2017-08-01 17:38         ` Stefan Beller
2017-08-02 12:22           ` [RFC] The correct and consistent alternative to quote a command ? Kaartic Sivaraam
2017-08-02 15:37             ` Junio C Hamano
2017-08-02 17:32             ` Stefan Beller
2017-08-03 15:35               ` Kaartic Sivaraam
2017-08-01 16:05       ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-08-01 16:05         ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-08-01 17:46           ` Stefan Beller
2017-08-02 12:32             ` Kaartic Sivaraam
2017-08-02 16:01               ` Junio C Hamano
2017-08-02 16:28                 ` Junio C Hamano
2017-08-02 17:58                   ` Stefan Beller
2017-08-07 14:34                     ` Kaartic Sivaraam
2017-08-07 14:33                 ` Kaartic Sivaraam
2017-08-01 21:04       ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8256C530C7DE43D7BC72BFB327DF4726@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaarticsivaraam91196@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).