From: "Torsten Bögershausen" <tboegi@web.de>
To: Anthony Sottile <asottile@umich.edu>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Regression (?) in core.safecrlf=false messaging
Date: Mon, 4 Jun 2018 21:15:21 +0200 [thread overview]
Message-ID: <81c6709d-8f8d-9387-1649-6bdc80c30ae8@web.de> (raw)
In-Reply-To: <CA+dzEBn7cCey-LDa1Y-PUeFQs7JiucS30FFiLfw4sfu6ZX34JQ@mail.gmail.com>
On 04.06.18 17:43, Anthony Sottile wrote:
> On Mon, Jun 4, 2018 at 12:55 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>>
>> Does the following patch fix your problem ?
>>
>> diff --git a/config.c b/config.c
>> index 6f8f1d8c11..c625aec96a 100644
>> --- a/config.c
>> +++ b/config.c
>> @@ -1233,7 +1233,7 @@ static int git_default_core_config(const char *var, const char *value)
>> }
>> eol_rndtrp_die = git_config_bool(var, value);
>> global_conv_flags_eol = eol_rndtrp_die ?
>> - CONV_EOL_RNDTRP_DIE : CONV_EOL_RNDTRP_WARN;
>> + CONV_EOL_RNDTRP_DIE : 0;
>> return 0;
>> }
>>
>
>
> Yes! After applying that patch:
>
> ```
>
> $ PATH=$PWD/prefix/bin:$PATH bash test.sh
> + git --version
> git version 2.18.0.rc1.dirty
> + rm -rf repo
> + git init repo
> Initialized empty Git repository in /tmp/git/repo/.git/
> + cd repo
> + git config core.autocrlf input
> + git config core.safecrlf false
> + echo -en 'foo\r\nbar\r\n'
> + git add f
>
> ```
>
> Anthony
>
Good.
Do you want to send the patch to the list ?
(You don't have too, if you don't want,
but as you already did all the work...)
prev parent reply other threads:[~2018-06-04 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 5:54 Regression (?) in core.safecrlf=false messaging Anthony Sottile
2018-06-04 7:38 ` Torsten Bögershausen
2018-06-04 7:55 ` Torsten Bögershausen
2018-06-04 15:43 ` Anthony Sottile
2018-06-04 19:15 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c6709d-8f8d-9387-1649-6bdc80c30ae8@web.de \
--to=tboegi@web.de \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).