git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: Re: make gitfakemmap standalone to fix linking error in git.c
Date: Mon, 5 Dec 2005 14:24:47 +0100	[thread overview]
Message-ID: <81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com> (raw)
In-Reply-To: <81b0412b0512050519k5ed80035x9eb4907f569e0a4b@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

The patch is to fix the error introduced by previous patch, which
inverted condition of checking for the supported case (start must be
NULL).

On 12/5/05, Alex Riesen <raa.lkml@gmail.com> wrote:
> The patch is to fix linking error because of gitfakemmap referencing
> die living in usage.c, and git.c not linking in the file. Instead of
> hardcoding usage.o in git.c prerequisites, I separated mmap from the
> main sources.

Why does it always happen...

[-- Attachment #2: 0002-fix-bug-introduced-by-previous-change.txt --]
[-- Type: text/plain, Size: 623 bytes --]

Subject: [PATCH] fix bug introduced by previous change

Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>


---

 compat/mmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

58d38f03086fe30f3f758f2f27fde0ad05107b4a
diff --git a/compat/mmap.c b/compat/mmap.c
index 98cf3cb..cfa1f25 100644
--- a/compat/mmap.c
+++ b/compat/mmap.c
@@ -9,7 +9,7 @@ void *gitfakemmap(void *start, size_t le
 {
 	int n = 0;
 
-	if (!start || !(flags & MAP_PRIVATE)) {
+	if (start || !(flags & MAP_PRIVATE)) {
 		fprintf(stderr, "Invalid usage of gitfakemmap.\n");
 		exit(128); /* see die() in ../usage.c */
 	}
-- 
0.99.9.GIT

  reply	other threads:[~2005-12-05 13:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-05 13:19 make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 13:24 ` Alex Riesen [this message]
2005-12-05 14:11   ` Petr Baudis
2005-12-05 15:43     ` Alex Riesen
2005-12-05 17:40   ` Junio C Hamano
2005-12-05 20:22     ` [PATCH] Clean up compatibility definitions Junio C Hamano
2005-12-05 20:36       ` Johannes Schindelin
2005-12-05 20:51         ` Junio C Hamano
2005-12-05 21:39           ` Alex Riesen
2005-12-06  7:35             ` Alex Riesen
2005-12-06  7:58               ` Junio C Hamano
2005-12-05 21:50       ` Alex Riesen
2005-12-05 21:58         ` Junio C Hamano
2005-12-06  7:15           ` Alex Riesen
2005-12-06  7:31             ` Junio C Hamano
2005-12-06  8:07               ` Alex Riesen
2005-12-06  8:11                 ` Junio C Hamano
2005-12-05 23:12       ` Petr Baudis
2005-12-06  3:17         ` Junio C Hamano
2005-12-06  9:53           ` Petr Baudis
2005-12-05 21:36     ` make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 21:49       ` Junio C Hamano
2005-12-06  7:49         ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).