From: Derrick Stolee <stolee@gmail.com>
To: Brandon Williams <bmwill@google.com>, git@vger.kernel.org
Cc: sbeller@google.com, gitster@pobox.com, peff@peff.net,
philipoakley@iee.org, jrnieder@gmail.com
Subject: Re: [PATCH v2 10/27] protocol: introduce enum protocol_version value protocol_v2
Date: Wed, 31 Jan 2018 09:54:41 -0500 [thread overview]
Message-ID: <815183f7-f449-1286-6dee-7cf6064bc5a1@gmail.com> (raw)
In-Reply-To: <20180125235838.138135-11-bmwill@google.com>
On 1/25/2018 6:58 PM, Brandon Williams wrote:
> Introduce protocol_v2, a new value for 'enum protocol_version'.
> Subsequent patches will fill in the implementation of protocol_v2.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> builtin/fetch-pack.c | 3 +++
> builtin/receive-pack.c | 6 ++++++
> builtin/send-pack.c | 3 +++
> builtin/upload-pack.c | 7 +++++++
> connect.c | 3 +++
> protocol.c | 2 ++
> protocol.h | 1 +
> remote-curl.c | 3 +++
> transport.c | 9 +++++++++
> 9 files changed, 37 insertions(+)
>
> diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
> index 85d4faf76..f492e8abd 100644
> --- a/builtin/fetch-pack.c
> +++ b/builtin/fetch-pack.c
> @@ -201,6 +201,9 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
> PACKET_READ_GENTLE_ON_EOF);
>
> switch (discover_version(&reader)) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> get_remote_heads(&reader, &ref, 0, NULL, &shallow);
> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index b7ce7c7f5..3656e94fd 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -1963,6 +1963,12 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
> unpack_limit = receive_unpack_limit;
>
> switch (determine_protocol_version_server()) {
> + case protocol_v2:
> + /*
> + * push support for protocol v2 has not been implemented yet,
> + * so ignore the request to use v2 and fallback to using v0.
> + */
> + break;
> case protocol_v1:
> /*
> * v1 is just the original protocol with a version string,
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 83cb125a6..b5427f75e 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -263,6 +263,9 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
> PACKET_READ_GENTLE_ON_EOF);
>
> switch (discover_version(&reader)) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> get_remote_heads(&reader, &remote_refs, REF_NORMAL,
> diff --git a/builtin/upload-pack.c b/builtin/upload-pack.c
> index 2cb5cb35b..8d53e9794 100644
> --- a/builtin/upload-pack.c
> +++ b/builtin/upload-pack.c
> @@ -47,6 +47,13 @@ int cmd_upload_pack(int argc, const char **argv, const char *prefix)
> die("'%s' does not appear to be a git repository", dir);
>
> switch (determine_protocol_version_server()) {
> + case protocol_v2:
> + /*
> + * fetch support for protocol v2 has not been implemented yet,
> + * so ignore the request to use v2 and fallback to using v0.
> + */
> + upload_pack(&opts);
> + break;
> case protocol_v1:
> /*
> * v1 is just the original protocol with a version string,
> diff --git a/connect.c b/connect.c
> index db3c9d24c..f2157a821 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -84,6 +84,9 @@ enum protocol_version discover_version(struct packet_reader *reader)
>
> /* Maybe process capabilities here, at least for v2 */
> switch (version) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> /* Read the peeked version line */
> packet_reader_read(reader);
> diff --git a/protocol.c b/protocol.c
> index 43012b7eb..5e636785d 100644
> --- a/protocol.c
> +++ b/protocol.c
> @@ -8,6 +8,8 @@ static enum protocol_version parse_protocol_version(const char *value)
> return protocol_v0;
> else if (!strcmp(value, "1"))
> return protocol_v1;
> + else if (!strcmp(value, "2"))
> + return protocol_v2;
> else
> return protocol_unknown_version;
> }
> diff --git a/protocol.h b/protocol.h
> index 1b2bc94a8..2ad35e433 100644
> --- a/protocol.h
> +++ b/protocol.h
> @@ -5,6 +5,7 @@ enum protocol_version {
> protocol_unknown_version = -1,
> protocol_v0 = 0,
> protocol_v1 = 1,
> + protocol_v2 = 2,
> };
>
> /*
> diff --git a/remote-curl.c b/remote-curl.c
> index 9f6d07683..dae8a4a48 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -185,6 +185,9 @@ static struct ref *parse_git_refs(struct discovery *heads, int for_push)
> PACKET_READ_GENTLE_ON_EOF);
>
> switch (discover_version(&reader)) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> get_remote_heads(&reader, &list, for_push ? REF_NORMAL : 0,
> diff --git a/transport.c b/transport.c
> index 2378dcb38..83d9dd1df 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -203,6 +203,9 @@ static struct ref *get_refs_via_connect(struct transport *transport, int for_pus
>
> data->version = discover_version(&reader);
> switch (data->version) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> get_remote_heads(&reader, &refs,
> @@ -250,6 +253,9 @@ static int fetch_refs_via_pack(struct transport *transport,
> refs_tmp = get_refs_via_connect(transport, 0);
>
> switch (data->version) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> refs = fetch_pack(&args, data->fd, data->conn,
> @@ -585,6 +591,9 @@ static int git_transport_push(struct transport *transport, struct ref *remote_re
> args.push_cert = SEND_PACK_PUSH_CERT_NEVER;
>
> switch (data->version) {
> + case protocol_v2:
> + die("support for protocol v2 not implemented yet");
> + break;
> case protocol_v1:
> case protocol_v0:
> ret = send_pack(&args, data->fd, data->conn, remote_refs,
With a macro approach to version selection, this change becomes simpler
in some ways and harder in others.
It is simpler in that we can have the macro from the previous commits
just fall back to version 0 behavior.
It is harder in that this commit would need one of two options:
1. A macro that performs an arbitrary statement when given v2, which
would be the die() for these actions not in v2.
2. A macro that clearly states v2 is not supported and calls die() on v2.
Here is my simple, untested attempt at a union of these options:
#define ON_PROTOCOL_VERSION(version,v0,v2) switch(version) {\
case protocol_v2:\
(v2);\
break;\
case protocol_v1:\
case protocol_v0:\
(v0);\
break;\
case protocol_unknown_version:\
BUG("unknown protocol version");\
}
#define ON_PROTOCOL_VERSION_V0_FALLBACK(version,v0) switch(version) {\
case protocol_v2:\
case protocol_v1:\
case protocol_v0:\
(v0);\
break;\
case protocol_unknown_version:\
BUG("unknown protocol version");\
}
#define ON_PROTOCOL_VERSION_V0_ONLY(version,v0) \
ON_PROTOCOL_VERSION(version,v0,\
BUG("support for protocol v2 not implemented yet"))
next prev parent reply other threads:[~2018-01-31 14:54 UTC|newest]
Thread overview: 362+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 0:18 [PATCH 00/26] protocol version 2 Brandon Williams
2018-01-03 0:18 ` [PATCH 01/26] pkt-line: introduce packet_read_with_status Brandon Williams
2018-01-03 19:27 ` Stefan Beller
2018-01-05 23:41 ` Brandon Williams
2018-01-09 18:04 ` Jonathan Tan
2018-01-09 19:28 ` Brandon Williams
2018-01-03 0:18 ` [PATCH 02/26] pkt-line: introduce struct packet_reader Brandon Williams
2018-01-09 18:08 ` Jonathan Tan
2018-01-09 19:19 ` Brandon Williams
2018-01-03 0:18 ` [PATCH 03/26] pkt-line: add delim packet support Brandon Williams
2018-01-03 0:18 ` [PATCH 04/26] upload-pack: convert to a builtin Brandon Williams
2018-01-03 20:33 ` Stefan Beller
2018-01-03 20:39 ` Brandon Williams
2018-02-21 21:47 ` Jonathan Nieder
2018-02-21 23:35 ` Junio C Hamano
2018-01-03 0:18 ` [PATCH 05/26] upload-pack: factor out processing lines Brandon Williams
2018-01-03 20:38 ` Stefan Beller
2018-01-03 0:18 ` [PATCH 06/26] transport: use get_refs_via_connect to get refs Brandon Williams
2018-01-03 21:20 ` Stefan Beller
2018-01-03 0:18 ` [PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader Brandon Williams
2018-01-09 18:27 ` Jonathan Tan
2018-01-09 19:09 ` Brandon Williams
2018-01-03 0:18 ` [PATCH 08/26] connect: discover protocol version outside of get_remote_heads Brandon Williams
2018-01-03 0:18 ` [PATCH 09/26] transport: store protocol version Brandon Williams
2018-01-09 18:41 ` Jonathan Tan
2018-01-09 19:15 ` Brandon Williams
2018-01-03 0:18 ` [PATCH 10/26] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams
2018-01-03 0:18 ` [PATCH 11/26] serve: introduce git-serve Brandon Williams
2018-01-09 20:24 ` Jonathan Tan
2018-01-09 22:16 ` Brandon Williams
2018-01-09 22:28 ` Jonathan Tan
2018-01-09 22:34 ` Brandon Williams
2018-02-01 18:48 ` Jeff Hostetler
2018-02-01 18:57 ` Stefan Beller
2018-02-01 19:09 ` Jeff Hostetler
2018-02-01 20:05 ` Brandon Williams
2018-02-01 19:45 ` Randall S. Becker
2018-02-01 20:08 ` 'Brandon Williams'
2018-02-01 20:37 ` Randall S. Becker
2018-02-01 20:50 ` Stefan Beller
2018-01-03 0:18 ` [PATCH 12/26] ls-refs: introduce ls-refs server command Brandon Williams
2018-01-04 0:17 ` Stefan Beller
2018-01-05 23:49 ` Brandon Williams
2018-01-09 20:50 ` Jonathan Tan
2018-01-16 19:23 ` Brandon Williams
2018-02-01 19:16 ` Jeff Hostetler
2018-02-07 0:55 ` Brandon Williams
2018-01-03 0:18 ` [PATCH 13/26] connect: request remote refs using v2 Brandon Williams
2018-01-09 22:24 ` Jonathan Tan
2018-01-03 0:18 ` [PATCH 14/26] transport: convert get_refs_list to take a list of ref patterns Brandon Williams
2018-01-03 0:18 ` [PATCH 15/26] transport: convert transport_get_remote_refs " Brandon Williams
2018-01-03 0:18 ` [PATCH 16/26] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams
2018-01-03 0:18 ` [PATCH 17/26] fetch: pass ref patterns when fetching Brandon Williams
2018-01-03 0:18 ` [PATCH 18/26] push: pass ref patterns when pushing Brandon Williams
2018-01-03 0:18 ` [PATCH 19/26] upload-pack: introduce fetch server command Brandon Williams
2018-01-04 1:07 ` Stefan Beller
2018-01-03 0:18 ` [PATCH 20/26] fetch-pack: perform a fetch using v2 Brandon Williams
2018-01-04 1:23 ` Stefan Beller
2018-01-05 23:55 ` Brandon Williams
2018-01-10 0:05 ` Jonathan Tan
2018-01-03 0:18 ` [PATCH 21/26] transport-helper: remove name parameter Brandon Williams
2018-01-03 0:18 ` [PATCH 22/26] transport-helper: refactor process_connect_service Brandon Williams
2018-01-03 0:18 ` [PATCH 23/26] transport-helper: introduce connect-half-duplex Brandon Williams
2018-01-03 0:18 ` [PATCH 24/26] pkt-line: add packet_buf_write_len function Brandon Williams
2018-01-03 0:18 ` [PATCH 25/26] remote-curl: create copy of the service name Brandon Williams
2018-01-03 0:18 ` [PATCH 26/26] remote-curl: implement connect-half-duplex command Brandon Williams
2018-01-10 0:10 ` Jonathan Tan
2018-01-10 17:57 ` Jonathan Tan
2018-01-11 1:09 ` Brandon Williams
2018-01-09 17:55 ` [PATCH 00/26] protocol version 2 Jonathan Tan
2018-01-11 0:23 ` Brandon Williams
2018-01-25 23:58 ` [PATCH v2 00/27] " Brandon Williams
2018-01-25 23:58 ` [PATCH v2 01/27] pkt-line: introduce packet_read_with_status Brandon Williams
2018-01-25 23:58 ` [PATCH v2 02/27] pkt-line: introduce struct packet_reader Brandon Williams
2018-01-25 23:58 ` [PATCH v2 03/27] pkt-line: add delim packet support Brandon Williams
2018-01-25 23:58 ` [PATCH v2 04/27] upload-pack: convert to a builtin Brandon Williams
2018-01-25 23:58 ` [PATCH v2 05/27] upload-pack: factor out processing lines Brandon Williams
2018-01-26 20:12 ` Stefan Beller
2018-01-26 21:33 ` Brandon Williams
2018-01-31 14:08 ` Derrick Stolee
2018-01-25 23:58 ` [PATCH v2 06/27] transport: use get_refs_via_connect to get refs Brandon Williams
2018-01-25 23:58 ` [PATCH v2 07/27] connect: convert get_remote_heads to use struct packet_reader Brandon Williams
2018-01-25 23:58 ` [PATCH v2 08/27] connect: discover protocol version outside of get_remote_heads Brandon Williams
2018-01-31 14:40 ` Derrick Stolee
2018-02-01 17:57 ` Brandon Williams
2018-01-25 23:58 ` [PATCH v2 09/27] transport: store protocol version Brandon Williams
2018-01-31 14:45 ` Derrick Stolee
2018-01-25 23:58 ` [PATCH v2 10/27] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams
2018-01-31 14:54 ` Derrick Stolee [this message]
2018-02-02 22:44 ` Brandon Williams
2018-02-05 14:14 ` Derrick Stolee
2018-01-25 23:58 ` [PATCH v2 11/27] test-pkt-line: introduce a packet-line test helper Brandon Williams
2018-01-25 23:58 ` [PATCH v2 12/27] serve: introduce git-serve Brandon Williams
2018-01-26 10:39 ` Duy Nguyen
2018-02-27 5:46 ` Jonathan Nieder
2018-01-31 15:39 ` Derrick Stolee
2018-01-25 23:58 ` [PATCH v2 13/27] ls-refs: introduce ls-refs server command Brandon Williams
2018-01-26 22:20 ` Stefan Beller
2018-02-02 22:31 ` Brandon Williams
2018-01-25 23:58 ` [PATCH v2 14/27] connect: request remote refs using v2 Brandon Williams
2018-01-31 15:22 ` Derrick Stolee
2018-01-31 20:10 ` Eric Sunshine
2018-01-31 22:14 ` Derrick Stolee
2018-01-25 23:58 ` [PATCH v2 15/27] transport: convert get_refs_list to take a list of ref patterns Brandon Williams
2018-01-25 23:58 ` [PATCH v2 16/27] transport: convert transport_get_remote_refs " Brandon Williams
2018-01-25 23:58 ` [PATCH v2 17/27] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams
2018-01-25 23:58 ` [PATCH v2 18/27] fetch: pass ref patterns when fetching Brandon Williams
2018-01-25 23:58 ` [PATCH v2 19/27] push: pass ref patterns when pushing Brandon Williams
2018-01-25 23:58 ` [PATCH v2 20/27] upload-pack: introduce fetch server command Brandon Williams
2018-01-25 23:58 ` [PATCH v2 21/27] fetch-pack: perform a fetch using v2 Brandon Williams
2018-01-25 23:58 ` [PATCH v2 22/27] transport-helper: remove name parameter Brandon Williams
2018-01-25 23:58 ` [PATCH v2 23/27] transport-helper: refactor process_connect_service Brandon Williams
2018-01-25 23:58 ` [PATCH v2 24/27] transport-helper: introduce stateless-connect Brandon Williams
2018-01-25 23:58 ` [PATCH v2 25/27] pkt-line: add packet_buf_write_len function Brandon Williams
2018-01-25 23:58 ` [PATCH v2 26/27] remote-curl: create copy of the service name Brandon Williams
2018-01-25 23:58 ` [PATCH v2 27/27] remote-curl: implement stateless-connect command Brandon Williams
2018-01-31 16:00 ` [PATCH v2 00/27] protocol version 2 Derrick Stolee
2018-02-07 0:58 ` Brandon Williams
2018-02-01 19:40 ` Jeff Hostetler
2018-02-07 1:12 ` [PATCH v3 00/35] " Brandon Williams
2018-02-07 1:12 ` [PATCH v3 01/35] pkt-line: introduce packet_read_with_status Brandon Williams
2018-02-13 0:25 ` Jonathan Nieder
2018-02-07 1:12 ` [PATCH v3 02/35] pkt-line: introduce struct packet_reader Brandon Williams
2018-02-13 0:49 ` Jonathan Nieder
2018-02-27 18:14 ` Brandon Williams
2018-02-27 19:20 ` Jonathan Nieder
2018-02-27 5:57 ` Jonathan Nieder
2018-02-27 6:12 ` Jonathan Nieder
2018-02-07 1:12 ` [PATCH v3 03/35] pkt-line: add delim packet support Brandon Williams
2018-02-22 19:13 ` Stefan Beller
2018-02-22 19:37 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 04/35] upload-pack: convert to a builtin Brandon Williams
2018-02-21 21:44 ` Jonathan Tan
2018-02-22 9:58 ` Jeff King
2018-02-22 18:07 ` Brandon Williams
2018-02-22 18:14 ` Jeff King
2018-02-22 19:38 ` Jonathan Nieder
2018-02-22 20:19 ` Jeff King
2018-02-22 20:21 ` Jeff King
2018-02-22 21:26 ` Jonathan Nieder
2018-02-22 21:44 ` Jeff King
2018-03-12 22:43 ` Jonathan Nieder
2018-03-12 23:28 ` Jeff King
2018-03-12 23:37 ` Jonathan Nieder
2018-03-12 23:52 ` Jeff King
2018-02-23 21:09 ` Brandon Williams
2018-03-03 4:24 ` Jeff King
2018-02-22 21:24 ` Jonathan Nieder
2018-02-22 21:44 ` Jeff King
2018-02-22 22:21 ` Jeff King
2018-02-22 22:42 ` Jonathan Nieder
2018-02-22 23:05 ` Jeff King
2018-02-22 23:23 ` Jeff King
2018-02-07 1:12 ` [PATCH v3 05/35] upload-pack: factor out processing lines Brandon Williams
2018-02-22 19:31 ` Stefan Beller
2018-02-22 19:39 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 06/35] transport: use get_refs_via_connect to get refs Brandon Williams
2018-02-27 6:08 ` Jonathan Nieder
2018-02-27 18:17 ` Brandon Williams
2018-02-27 19:25 ` Jonathan Nieder
2018-02-27 19:46 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader Brandon Williams
2018-02-22 19:52 ` Stefan Beller
2018-02-22 20:09 ` Stefan Beller
2018-02-23 21:30 ` Brandon Williams
2018-02-23 21:48 ` Stefan Beller
2018-02-23 22:56 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams
2018-02-21 22:11 ` Jonathan Tan
2018-02-22 18:17 ` Brandon Williams
2018-02-22 19:22 ` Jonathan Tan
2018-02-07 1:12 ` [PATCH v3 09/35] transport: store protocol version Brandon Williams
2018-02-07 1:12 ` [PATCH v3 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams
2018-02-27 6:18 ` Jonathan Nieder
2018-02-27 18:41 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams
2018-02-22 20:40 ` Stefan Beller
2018-02-23 21:22 ` Brandon Williams
2018-03-03 4:25 ` Jeff King
2018-03-05 18:48 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 12/35] serve: introduce git-serve Brandon Williams
2018-02-21 22:45 ` Jonathan Tan
2018-02-23 21:33 ` Brandon Williams
2018-02-27 18:05 ` Jonathan Tan
2018-02-27 18:34 ` Brandon Williams
2018-02-22 9:33 ` Jeff King
2018-02-23 21:45 ` Brandon Williams
2018-03-03 4:33 ` Jeff King
2018-03-05 18:43 ` Brandon Williams
2018-03-05 20:52 ` Jeff King
2018-03-05 21:36 ` Jonathan Nieder
2018-03-06 6:29 ` Jeff King
2018-03-12 23:46 ` Jeff King
2018-02-07 1:12 ` [PATCH v3 13/35] ls-refs: introduce ls-refs server command Brandon Williams
2018-02-22 9:48 ` Jeff King
2018-02-23 0:45 ` Brandon Williams
2018-02-24 0:19 ` Brandon Williams
2018-02-24 4:03 ` Jeff King
2018-02-24 4:01 ` Jeff King
2018-02-26 22:33 ` Junio C Hamano
2018-02-27 0:02 ` Ævar Arnfjörð Bjarmason
2018-02-27 5:15 ` Jonathan Nieder
2018-02-27 18:02 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 14/35] connect: request remote refs using v2 Brandon Williams
2018-02-21 22:54 ` Jonathan Tan
2018-02-22 18:19 ` Brandon Williams
2018-02-22 18:26 ` Jeff King
2018-02-22 19:25 ` Jonathan Tan
2018-02-27 6:21 ` Jonathan Nieder
2018-02-27 21:58 ` Junio C Hamano
2018-02-27 22:04 ` Jeff King
2018-02-27 22:10 ` Eric Sunshine
2018-02-27 22:18 ` Jeff King
2018-02-27 23:32 ` Junio C Hamano
2018-02-27 6:51 ` Jonathan Nieder
2018-02-27 19:30 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams
2018-02-21 22:56 ` Jonathan Tan
2018-02-22 18:25 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 16/35] transport: convert transport_get_remote_refs " Brandon Williams
2018-02-21 22:58 ` Jonathan Tan
2018-02-22 18:26 ` Brandon Williams
2018-02-22 19:32 ` Jonathan Tan
2018-02-22 19:51 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams
2018-02-07 1:12 ` [PATCH v3 18/35] fetch: pass ref patterns when fetching Brandon Williams
2018-02-27 6:53 ` Jonathan Nieder
2018-02-07 1:12 ` [PATCH v3 19/35] push: pass ref patterns when pushing Brandon Williams
2018-02-27 18:23 ` Stefan Beller
2018-02-07 1:12 ` [PATCH v3 20/35] upload-pack: introduce fetch server command Brandon Williams
2018-02-21 23:46 ` Jonathan Tan
2018-02-22 18:48 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 21/35] fetch-pack: perform a fetch using v2 Brandon Williams
2018-02-24 0:54 ` Jonathan Tan
2018-02-26 22:23 ` Brandon Williams
2018-02-27 19:27 ` Stefan Beller
2018-02-27 19:40 ` Brandon Williams
2018-02-07 1:12 ` [PATCH v3 22/35] upload-pack: support shallow requests Brandon Williams
2018-02-07 19:00 ` Stefan Beller
2018-02-10 10:23 ` Duy Nguyen
2018-02-13 17:06 ` Brandon Williams
2018-02-27 18:29 ` Jonathan Nieder
2018-02-27 18:57 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 23/35] fetch-pack: " Brandon Williams
2018-02-23 19:37 ` Jonathan Tan
2018-02-23 19:56 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once Brandon Williams
2018-02-21 23:51 ` Jonathan Tan
2018-02-07 1:13 ` [PATCH v3 25/35] connect: don't request v2 when pushing Brandon Williams
2018-02-07 1:13 ` [PATCH v3 26/35] transport-helper: remove name parameter Brandon Williams
2018-02-27 23:03 ` Jonathan Nieder
2018-02-07 1:13 ` [PATCH v3 27/35] transport-helper: refactor process_connect_service Brandon Williams
2018-02-07 1:13 ` [PATCH v3 28/35] transport-helper: introduce stateless-connect Brandon Williams
2018-02-22 0:01 ` Jonathan Tan
2018-02-22 18:53 ` Brandon Williams
2018-02-22 21:55 ` Jonathan Tan
2018-02-27 23:30 ` Jonathan Nieder
2018-02-28 19:09 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 29/35] pkt-line: add packet_buf_write_len function Brandon Williams
2018-02-27 23:11 ` Jonathan Nieder
2018-02-28 1:08 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 30/35] remote-curl: create copy of the service name Brandon Williams
2018-02-22 0:06 ` Jonathan Tan
2018-02-22 18:56 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 31/35] remote-curl: store the protocol version the server responded with Brandon Williams
2018-02-27 23:17 ` Jonathan Nieder
2018-02-07 1:13 ` [PATCH v3 32/35] http: allow providing extra headers for http requests Brandon Williams
2018-02-22 0:09 ` Jonathan Tan
2018-02-22 18:58 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 33/35] http: don't always add Git-Protocol header Brandon Williams
2018-02-07 1:13 ` [PATCH v3 34/35] remote-curl: implement stateless-connect command Brandon Williams
2018-02-28 0:05 ` Jonathan Nieder
2018-02-28 20:21 ` Brandon Williams
2018-02-07 1:13 ` [PATCH v3 35/35] remote-curl: don't request v2 when pushing Brandon Williams
2018-02-22 0:12 ` Jonathan Tan
2018-02-22 18:59 ` Brandon Williams
2018-02-22 19:09 ` Brandon Williams
2018-02-12 14:50 ` [PATCH v3 00/35] protocol version 2 Derrick Stolee
2018-02-21 20:01 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 " Brandon Williams
2018-02-28 23:22 ` [PATCH v4 01/35] pkt-line: introduce packet_read_with_status Brandon Williams
2018-03-13 19:35 ` Jonathan Tan
2018-03-13 19:52 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 02/35] pkt-line: allow peeking a packet line without consuming it Brandon Williams
2018-03-01 20:48 ` Junio C Hamano
2018-03-12 21:56 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 03/35] pkt-line: add delim packet support Brandon Williams
2018-03-01 20:50 ` Junio C Hamano
2018-03-01 21:04 ` Junio C Hamano
2018-03-01 22:49 ` Brandon Williams
2018-03-01 23:43 ` Junio C Hamano
2018-02-28 23:22 ` [PATCH v4 04/35] upload-pack: convert to a builtin Brandon Williams
2018-03-13 16:40 ` Jonathan Tan
2018-03-13 19:50 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 05/35] upload-pack: factor out processing lines Brandon Williams
2018-03-01 21:25 ` Junio C Hamano
2018-03-12 22:24 ` Brandon Williams
2018-03-12 22:39 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 06/35] transport: use get_refs_via_connect to get refs Brandon Williams
2018-03-01 21:25 ` Junio C Hamano
2018-02-28 23:22 ` [PATCH v4 07/35] connect: convert get_remote_heads to use struct packet_reader Brandon Williams
2018-02-28 23:22 ` [PATCH v4 08/35] connect: discover protocol version outside of get_remote_heads Brandon Williams
2018-03-13 15:49 ` Jonathan Tan
2018-02-28 23:22 ` [PATCH v4 09/35] transport: store protocol version Brandon Williams
2018-02-28 23:22 ` [PATCH v4 10/35] protocol: introduce enum protocol_version value protocol_v2 Brandon Williams
2018-02-28 23:22 ` [PATCH v4 11/35] test-pkt-line: introduce a packet-line test helper Brandon Williams
2018-02-28 23:22 ` [PATCH v4 12/35] serve: introduce git-serve Brandon Williams
2018-03-01 23:11 ` Junio C Hamano
2018-03-12 22:08 ` Brandon Williams
2018-03-02 20:42 ` Junio C Hamano
2018-03-13 21:40 ` Brandon Williams
2018-03-02 20:56 ` Junio C Hamano
2018-03-13 21:35 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 13/35] ls-refs: introduce ls-refs server command Brandon Williams
2018-03-02 21:13 ` Junio C Hamano
2018-03-13 21:27 ` Brandon Williams
2018-03-03 4:43 ` Jeff King
2018-03-05 18:21 ` Brandon Williams
2018-03-05 18:29 ` Jonathan Nieder
2018-03-05 20:38 ` Jeff King
2018-03-05 20:28 ` Jeff King
2018-03-13 21:23 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 14/35] connect: request remote refs using v2 Brandon Williams
2018-02-28 23:22 ` [PATCH v4 15/35] transport: convert get_refs_list to take a list of ref patterns Brandon Williams
2018-02-28 23:22 ` [PATCH v4 16/35] transport: convert transport_get_remote_refs " Brandon Williams
2018-03-13 16:00 ` Jonathan Tan
2018-02-28 23:22 ` [PATCH v4 17/35] ls-remote: pass ref patterns when requesting a remote's refs Brandon Williams
2018-03-02 22:13 ` Junio C Hamano
2018-02-28 23:22 ` [PATCH v4 18/35] fetch: pass ref patterns when fetching Brandon Williams
2018-03-02 22:20 ` Junio C Hamano
2018-03-12 22:18 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 19/35] push: pass ref patterns when pushing Brandon Williams
2018-03-02 22:25 ` Junio C Hamano
2018-03-12 22:20 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 20/35] upload-pack: introduce fetch server command Brandon Williams
2018-03-13 16:20 ` Jonathan Tan
2018-03-13 21:49 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 21/35] fetch-pack: perform a fetch using v2 Brandon Williams
2018-02-28 23:22 ` [PATCH v4 22/35] fetch-pack: support shallow requests Brandon Williams
2018-02-28 23:22 ` [PATCH v4 23/35] connect: refactor git_connect to only get the protocol version once Brandon Williams
2018-02-28 23:22 ` [PATCH v4 24/35] connect: don't request v2 when pushing Brandon Williams
2018-02-28 23:22 ` [PATCH v4 25/35] transport-helper: remove name parameter Brandon Williams
2018-02-28 23:22 ` [PATCH v4 26/35] transport-helper: refactor process_connect_service Brandon Williams
2018-02-28 23:22 ` [PATCH v4 27/35] transport-helper: introduce stateless-connect Brandon Williams
2018-03-13 16:30 ` Jonathan Tan
2018-03-14 17:36 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 28/35] pkt-line: add packet_buf_write_len function Brandon Williams
2018-02-28 23:22 ` [PATCH v4 29/35] remote-curl: create copy of the service name Brandon Williams
2018-03-13 16:32 ` Jonathan Tan
2018-02-28 23:22 ` [PATCH v4 30/35] remote-curl: store the protocol version the server responded with Brandon Williams
2018-02-28 23:22 ` [PATCH v4 31/35] http: allow providing extra headers for http requests Brandon Williams
2018-03-13 16:33 ` Jonathan Tan
2018-02-28 23:22 ` [PATCH v4 32/35] http: don't always add Git-Protocol header Brandon Williams
2018-02-28 23:22 ` [PATCH v4 33/35] http: eliminate "# service" line when using protocol v2 Brandon Williams
2018-02-28 23:22 ` [PATCH v4 34/35] remote-curl: implement stateless-connect command Brandon Williams
2018-03-02 20:07 ` Johannes Schindelin
2018-03-05 19:35 ` Brandon Williams
2018-02-28 23:22 ` [PATCH v4 35/35] remote-curl: don't request v2 when pushing Brandon Williams
2018-03-13 16:35 ` Jonathan Tan
2018-03-01 18:41 ` [PATCH v4 00/35] protocol version 2 Junio C Hamano
2018-03-01 19:16 ` Brandon Williams
2018-03-01 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=815183f7-f449-1286-6dee-7cf6064bc5a1@gmail.com \
--to=stolee@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).