From: Michael J Gruber <git@drmicha.warpmail.net>
To: git@vger.kernel.org
Subject: [PATCH] replace: parse revision argument for -d
Date: Fri, 26 Oct 2012 15:33:27 +0200 [thread overview]
Message-ID: <807340e40adb1fc97cd97161fe1fabd292bc79c3.1351258394.git.git@drmicha.warpmail.net> (raw)
'git replace' parses the revision arguments when it creates replacements
(so that a sha1 can be abbreviated, e.g.) but not when deleting
replacements.
This sucks.
Make it parse the argument to 'replace -d' in the same way.
Just in case someone lost the replacement object before deleting the
replacement, take the argument literally if it can not be resolved to a
full sha1.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
builtin/replace.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/builtin/replace.c b/builtin/replace.c
index e3aaf70..80e2039 100644
--- a/builtin/replace.c
+++ b/builtin/replace.c
@@ -46,24 +46,29 @@ typedef int (*each_replace_name_fn)(const char *name, const char *ref,
static int for_each_replace_name(const char **argv, each_replace_name_fn fn)
{
- const char **p;
+ const char **p, *q;
char ref[PATH_MAX];
int had_error = 0;
unsigned char sha1[20];
for (p = argv; *p; p++) {
- if (snprintf(ref, sizeof(ref), "refs/replace/%s", *p)
+ q = *p;
+ if (get_sha1(q, sha1))
+ warning("Failed to resolve '%s' as a valid ref; taking it literally.", q);
+ else
+ q = sha1_to_hex(sha1);
+ if (snprintf(ref, sizeof(ref), "refs/replace/%s", q)
>= sizeof(ref)) {
- error("replace ref name too long: %.*s...", 50, *p);
+ error("replace ref name too long: %.*s...", 50, q);
had_error = 1;
continue;
}
if (read_ref(ref, sha1)) {
- error("replace ref '%s' not found.", *p);
+ error("replace ref '%s' not found.", q);
had_error = 1;
continue;
}
- if (fn(*p, ref, sha1))
+ if (fn(q, ref, sha1))
had_error = 1;
}
return had_error;
--
1.8.0.370.g8cbad08
next reply other threads:[~2012-10-26 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 13:33 Michael J Gruber [this message]
2012-10-26 15:25 ` [PATCH] replace: parse revision argument for -d Christian Couder
2012-10-29 6:58 ` Jeff King
2012-10-29 9:02 ` Michael J Gruber
2012-10-29 9:04 ` Jeff King
2012-10-29 10:08 ` Michael J Gruber
2012-10-29 13:23 ` [PATCHv2] " Michael J Gruber
2012-11-09 16:48 ` Jeff King
2012-11-12 8:51 ` Michael J Gruber
2012-11-12 14:18 ` [PATCHv3] " Michael J Gruber
2012-11-12 20:42 ` Jeff King
2012-11-13 10:25 ` Michael J Gruber
2012-11-13 10:34 ` [PATCHv4] " Michael J Gruber
2012-11-13 13:37 ` Jeff King
2012-11-13 10:30 ` Notes in format-patch (was: Re: [PATCHv3] replace: parse revision argument for -d) Michael J Gruber
2012-11-13 13:38 ` Jeff King
2012-11-13 16:29 ` Notes in format-patch Junio C Hamano
2012-11-13 16:56 ` Junio C Hamano
2012-11-13 17:26 ` Junio C Hamano
2012-11-13 18:09 ` Junio C Hamano
2012-11-14 9:17 ` Michael J Gruber
2012-11-14 13:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807340e40adb1fc97cd97161fe1fabd292bc79c3.1351258394.git.git@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).