From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add verbose comments to split_msg()
Date: Mon, 11 Dec 2006 17:15:30 -0800 [thread overview]
Message-ID: <7vzm9tzzgt.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200612112212.51533.andyparkins@gmail.com
Andy Parkins <andyparkins@gmail.com> writes:
> I was going to fix a bug in imap-send that was making it include the "From "
> line from git-format-patch in the message sent to the IMAP server. So I
> commented up what split_msg already does.
>
> It turns out the bug was fixed in commit
> e0b0830726286287744cc9e1a629a534bbe75452. So comments only, no fix needed.
> (cherry picked from 3d5b1768f15b5cd430b869f416e72f4f3afe3d4a commit)
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
3d5b1768 is not a public commit and is not useful information
other than your self. Please omit the last line.
Linus and everybody was right and I was wrong to leave this
message default in git-cherry-pick for a long time.
> ---
> imap-send.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index a6a6568..110bd54 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1216,35 +1216,48 @@ split_msg( msg_data_t *all_msgs, msg_data_t *msg, int *ofs )
> {
> char *p, *data;
>
> + /* Clear this message's slot */
> memset( msg, 0, sizeof *msg );
> + /* If we've run out of data, stop*/
"..., stop */"
> if (*ofs >= all_msgs->len)
> return 0;
>
> + /* Point at the next message chunk */
> data = &all_msgs->data[ *ofs ];
> + /* This message length is at most, the length of all messages
> + * minus our current position */
Style?
/*
* This message ...
* ... position.
*/
> msg->len = all_msgs->len - *ofs;
>
> + /* If there isn't enough data remaining for a whole message or there
> + * is no , give up */
"there is no , "???
next prev parent reply other threads:[~2006-12-12 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 22:12 [PATCH] Add verbose comments to split_msg() Andy Parkins
2006-12-12 1:15 ` Junio C Hamano [this message]
2006-12-12 8:20 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzm9tzzgt.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).