git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Hash name is SHA-1
Date: Fri, 26 Jan 2007 15:46:00 -0800	[thread overview]
Message-ID: <7vzm85tkqv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200701261154.20723.andyparkins@gmail.com

Andy Parkins <andyparkins@gmail.com> writes:

> As a further to the above cleanups, I'm also planning to fix all the sha1 
> named variables to be "hash" or "object" or something.  It strikes me that 
> this plan is related to this cleanup and might fix some of the issues like:
>
>> +       "git-read-tree (<sha> | "
>> +       "[[-m [--aggressive] | --reset | --prefix=<prefix>] "
>> +       "[-u | -i]] [--exclude-per-directory=<gitignore>] "
>> +       "<sha1> [<sha2> [<sha3>]])";

I've thought about this more than once but I do not think it is
worth to rename variable and functions wholesale.  When we do
fix-ups to a particular function that has "unsigned char
sha1[20]" renaming the variable to hash[OBNAME_SIZE] at the same
time would be of less impact, although the clean-up may take
longer.

On the other hand, I think the usage strings are fair game.

  reply	other threads:[~2007-01-26 23:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 12:50 Some cleanups Horst H. von Brand
2007-01-25 12:50 ` [PATCH] Hash name is SHA-1 Horst H. von Brand
2007-01-25 17:01   ` Shawn O. Pearce
2007-01-25 17:10     ` Nicolas Pitre
2007-01-25 18:56       ` Horst H. von Brand
2007-01-25 19:05         ` Shawn O. Pearce
2007-01-25 23:03   ` Matthias Lederhofer
2007-01-25 23:44     ` Junio C Hamano
2007-01-26 11:54       ` Andy Parkins
2007-01-26 23:46         ` Junio C Hamano [this message]
2007-01-26 11:34   ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzm85tkqv.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).