git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Smith <msmith@cbnco.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] svnimport/cvsimport: force creation of tags that already exist.
Date: Fri, 07 Sep 2007 13:54:01 -0700	[thread overview]
Message-ID: <7vzlzy2o46.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0709071125090.6203@juice.ott.cti.com> (Michael Smith's message of "Fri, 7 Sep 2007 11:42:22 -0400 (EDT)")

Michael Smith <msmith@cbnco.com> writes:

> I understand moving tags is frowned upon in Git. I don't know how common 
> the practise is in Subversion and CVS, or whether it makes sense to 
> make the import scripts force tag creation by default.

I think the patch itself makes sense.  If for some reason the
importer detects that the CVS or SVN history moved a tag, we
either:

    (1) have a way to keep track of the versions of the tag; or
    (2) allow it and make it "last one wins" semantics; or
    (3) ignore it and make it "first one wins" semantics.  

Erroring out complaining that the tag cannot be created, as the
current code does, does not make any sense.

The patch needs to be accompanied with a better commit log
description.  I am guessing that with your change the semantics
would become (2) above (assuming that cvsps or whoever reads the
history of the other side gives events in chronological order),
but you should not force readers of your commit log message to
guess.

  reply	other threads:[~2007-09-07 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07 15:42 [RFC] svnimport/cvsimport: force creation of tags that already exist Michael Smith
2007-09-07 20:54 ` Junio C Hamano [this message]
2007-09-07 21:35   ` [PATCH] (cvs|svn)import: Ask git-tag to overwrite old tags Michael Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzlzy2o46.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=msmith@cbnco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).