From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Implement git commit as a builtin command. Date: Thu, 01 Nov 2007 13:30:21 -0700 Message-ID: <7vzlxxaeua.fsf@gitster.siamese.dyndns.org> References: <1193944163-22892-1-git-send-email-krh@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org To: Kristian =?utf-8?Q?H=C3=B8gsberg?= X-From: git-owner@vger.kernel.org Thu Nov 01 21:30:58 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Inggj-0000O5-K0 for gcvg-git-2@gmane.org; Thu, 01 Nov 2007 21:30:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbXKAUa2 convert rfc822-to-quoted-printable (ORCPT ); Thu, 1 Nov 2007 16:30:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752740AbXKAUa1 (ORCPT ); Thu, 1 Nov 2007 16:30:27 -0400 Received: from sceptre.pobox.com ([207.106.133.20]:48105 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810AbXKAUa1 convert rfc822-to-8bit (ORCPT ); Thu, 1 Nov 2007 16:30:27 -0400 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 195C72EF; Thu, 1 Nov 2007 16:30:48 -0400 (EDT) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 71101911F1; Thu, 1 Nov 2007 16:30:45 -0400 (EDT) In-Reply-To: <1193944163-22892-1-git-send-email-krh@redhat.com> (Kristian =?utf-8?Q?H=C3=B8gsberg's?= message of "Thu, 1 Nov 2007 15:09:23 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Kristian H=C3=B8gsberg writes: > Move git-commit.sh to contrib/examples. > > Signed-off-by: Kristian H=C3=B8gsberg > --- > > Here's the builtin-commit patch again, this time updated to build > against the in-tree strbuf and option parser. Now that Pierre has > done all the work of getting those pieces upstream, I notice that the > C version ends up 20 lines shorter than the shell script :) > > There's a couple of changes to the test suite at the end, which > removes some EDITOR=3D: VISUAL=3D: hard-coding in a few tests and the= n > sets the default editor to /bin/true. This is to address the problem > that the C version of launch editor doesn't support any kind of shell > qouting or built-ins. Should we just use system(3) here? I do not care much about _how_ it is done, but one of the most often typed command in my .history is EDITOR=3D: git commit I'd be somewhat unhappy to be forced to retrain my fingers ;-)