* wrong expectation from "git log -p"
@ 2009-06-02 0:34 Thomas Spura
2009-06-02 0:54 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Spura @ 2009-06-02 0:34 UTC (permalink / raw)
To: git
If running "git log -p parse-options.*", the last commit is
df217ed6430efe444a09fffdafd39720ae3f9864
There are the changes this commit makes towards parse-options.*.
I was expecting to see the full commit with all changes and not only
towards the 2 files - only including the two files.
Is my expactation wrong or is this a bug?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wrong expectation from "git log -p"
2009-06-02 0:34 wrong expectation from "git log -p" Thomas Spura
@ 2009-06-02 0:54 ` Junio C Hamano
2009-06-03 12:22 ` [PATCH] completion: Add --full-diff to log/gitk options Todd Zullinger
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2009-06-02 0:54 UTC (permalink / raw)
To: Thomas Spura; +Cc: git
Thomas Spura <tomspur@fedoraproject.org> writes:
> If running "git log -p parse-options.*", the last commit is
> df217ed6430efe444a09fffdafd39720ae3f9864
> There are the changes this commit makes towards parse-options.*.
>
> I was expecting to see the full commit with all changes and not only
> towards the 2 files - only including the two files.
>
> Is my expactation wrong or is this a bug?
Time to run "man git-log" and look for --full-diff, perhaps?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] completion: Add --full-diff to log/gitk options
2009-06-02 0:54 ` Junio C Hamano
@ 2009-06-03 12:22 ` Todd Zullinger
2009-06-03 14:30 ` Thomas Rast
0 siblings, 1 reply; 6+ messages in thread
From: Todd Zullinger @ 2009-06-03 12:22 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Shawn O. Pearce, Thomas Spura, git
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
Junio C Hamano wrote:
> Thomas Spura <tomspur@fedoraproject.org> writes:
>
>> If running "git log -p parse-options.*", the last commit is
>> df217ed6430efe444a09fffdafd39720ae3f9864
>> There are the changes this commit makes towards parse-options.*.
>>
>> I was expecting to see the full commit with all changes and not only
>> towards the 2 files - only including the two files.
>>
>> Is my expactation wrong or is this a bug?
>
> Time to run "man git-log" and look for --full-diff, perhaps?
While this patch won't do much to help people find the option, perhaps
those who learn about it will appreciate not having to type it. :)
I *think* __git_log_gitk_options is the proper place for it, but it's
early in the a.m. and I'm not averse to being proved wrong.
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 0c8bb53..2b291ea 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1117,7 +1117,7 @@ __git_log_common_options="
"
# Options that go well for log and gitk (not shortlog)
__git_log_gitk_options="
- --dense --sparse --full-history
+ --dense --sparse --full-diff --full-history
--simplify-merges --simplify-by-decoration
--left-right
"
--
1.6.3.1
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Going to hell when I die would just be redundant.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] completion: Add --full-diff to log/gitk options
2009-06-03 12:22 ` [PATCH] completion: Add --full-diff to log/gitk options Todd Zullinger
@ 2009-06-03 14:30 ` Thomas Rast
2009-06-03 20:20 ` [PATCH v2] completion: Add --full-diff to log options Todd Zullinger
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Rast @ 2009-06-03 14:30 UTC (permalink / raw)
To: Todd Zullinger; +Cc: Junio C Hamano, Shawn O. Pearce, Thomas Spura, git
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
Todd Zullinger wrote:
> I *think* __git_log_gitk_options is the proper place for it, but it's
> early in the a.m. and I'm not averse to being proved wrong.
[...]
> # Options that go well for log and gitk (not shortlog)
> __git_log_gitk_options="
> - --dense --sparse --full-history
> + --dense --sparse --full-diff --full-history
Gitk has its own setting in the Preferences called "limit diffs to
listed paths", and ignores this option, so it should go directly in
_git_log.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] completion: Add --full-diff to log options
2009-06-03 14:30 ` Thomas Rast
@ 2009-06-03 20:20 ` Todd Zullinger
2009-07-05 8:35 ` Eric Wong
0 siblings, 1 reply; 6+ messages in thread
From: Todd Zullinger @ 2009-06-03 20:20 UTC (permalink / raw)
To: Thomas Rast; +Cc: Junio C Hamano, Shawn O. Pearce, Thomas Spura, git
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
Thomas Rast wrote:
> Todd Zullinger wrote:
>> I *think* __git_log_gitk_options is the proper place for it, but it's
>> early in the a.m. and I'm not averse to being proved wrong.
> [...]
>> # Options that go well for log and gitk (not shortlog)
>> __git_log_gitk_options="
>> - --dense --sparse --full-history
>> + --dense --sparse --full-diff --full-history
>
> Gitk has its own setting in the Preferences called "limit diffs to
> listed paths", and ignores this option, so it should go directly in
> _git_log.
Ahh, thanks Thomas.
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 98b9cbe..79a99af 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1157,7 +1157,7 @@ _git_log ()
$__git_log_shortlog_options
$__git_log_gitk_options
--root --topo-order --date-order --reverse
- --follow
+ --follow --full-diff
--abbrev-commit --abbrev=
--relative-date --date=
--pretty= --format= --oneline
--
1.6.3.1
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I have to decide between two equally frightening options. If I wanted
to do that, I'd vote.
-- Duckman
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] completion: Add --full-diff to log options
2009-06-03 20:20 ` [PATCH v2] completion: Add --full-diff to log options Todd Zullinger
@ 2009-07-05 8:35 ` Eric Wong
0 siblings, 0 replies; 6+ messages in thread
From: Eric Wong @ 2009-07-05 8:35 UTC (permalink / raw)
To: Junio C Hamano
Cc: Thomas Rast, Shawn O. Pearce, Todd Zullinger, Thomas Spura, git
Todd Zullinger <tmz@pobox.com> wrote:
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
I was just missing this completion for "git log" myself.
Acked-by: Eric Wong <normalperson@yhbt.net>
> ---
> contrib/completion/git-completion.bash | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 98b9cbe..79a99af 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1157,7 +1157,7 @@ _git_log ()
> $__git_log_shortlog_options
> $__git_log_gitk_options
> --root --topo-order --date-order --reverse
> - --follow
> + --follow --full-diff
> --abbrev-commit --abbrev=
> --relative-date --date=
> --pretty= --format= --oneline
> --
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-05 8:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-02 0:34 wrong expectation from "git log -p" Thomas Spura
2009-06-02 0:54 ` Junio C Hamano
2009-06-03 12:22 ` [PATCH] completion: Add --full-diff to log/gitk options Todd Zullinger
2009-06-03 14:30 ` Thomas Rast
2009-06-03 20:20 ` [PATCH v2] completion: Add --full-diff to log options Todd Zullinger
2009-07-05 8:35 ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).