From: Junio C Hamano <gitster@pobox.com>
To: Manlio Perillo <manlio.perillo@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: add support for path completion
Date: Mon, 17 Dec 2012 11:42:04 -0800 [thread overview]
Message-ID: <7vzk1clb3n.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50CEFF3A.4050802@gmail.com> (Manlio Perillo's message of "Mon, 17 Dec 2012 12:17:14 +0100")
Manlio Perillo <manlio.perillo@gmail.com> writes:
>> As long as all of the above stops completion at directory boundary,
>> I think the above sounds like a sensible thing to do. e.g. when
>> "ls-files" gives Documentation/Makefile and Documentation/git.txt,
>> "git cmd Doc<TAB>" first would give "git cmd Documentation/" and
>> then the second <TAB> would offer these two paths as choices. That
>> way, the user can choose to just execute "git cmd Documentation/"
>> without even looking at these individual paths.
>
> Right, this is what bash usually do.
> However I don't know how to implement this with git.
That sounds like a regression to me.
>> I am not sure how you would handle the last parameter to "git mv",
>> though. That is by definition a path that does not exist,
>> i.e. cannot be completed.
>
> Right, the code should be changed.
> No completion should be done for the second parameter.
I deliberately wrote "the last" not "the second", as you can do
$ mkdir X
$ git mv COPYING README X/.
You do need to expand the second parameter to README when the user
types
git mv COPYING REAMDE X
then goes back with \C-b to "M", types \C-d three times to remove
"MDE", and then finally says <TAB>, to result in
git mv COPYING README X
next prev parent reply other threads:[~2012-12-17 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 21:24 [PATCH] git-completion.bash: add support for path completion Manlio Perillo
2012-12-17 4:50 ` Junio C Hamano
2012-12-17 11:17 ` Manlio Perillo
2012-12-17 19:42 ` Junio C Hamano [this message]
2012-12-18 16:25 ` Manlio Perillo
2012-12-19 22:02 ` Manlio Perillo
2012-12-19 22:49 ` Junio C Hamano
2012-12-19 23:50 ` Manlio Perillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzk1clb3n.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=manlio.perillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).