From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: [BUG] two-way read-tree can write null sha1s into index
Date: Thu, 03 Jan 2013 14:33:09 -0800 [thread overview]
Message-ID: <7vzk0pvqvu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130103203606.GA8188@sigill.intra.peff.net> (Jeff King's message of "Thu, 3 Jan 2013 15:36:07 -0500")
Jeff King <peff@peff.net> writes:
> Oh, I agree it's insane to try to carry through unmerged entries. I'm
> just concerned that not all code paths are careful enough to check.
I would actually be surprised if some code path do assume somebody
might give them an index with conflicting entries in it and guard
against it. We have been coding under the "index must exactly match
the second tree when three-way unpack_trees() begin" requirement
since day one. An conflicted entry will appear as "index and HEAD
not matching" and will cause reject_merge() early in threeway_merge()
anyway, no?
next prev parent reply other threads:[~2013-01-03 22:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 15:01 [PATCH 0/3] null sha1 in trees Jeff King
2012-07-28 15:03 ` [PATCH 1/3] diff: do not use null sha1 as a sentinel value Jeff King
2012-07-28 15:05 ` [PATCH 2/3] do not write null sha1s to on-disk index Jeff King
2012-12-29 10:03 ` Jonathan Nieder
2012-12-29 10:27 ` Jeff King
2012-12-29 10:34 ` Jonathan Nieder
2012-12-29 10:42 ` Jeff King
2012-12-29 10:51 ` Jonathan Nieder
2012-12-29 11:05 ` Jeff King
2012-12-29 20:51 ` [BUG] two-way read-tree can write null sha1s into index Jeff King
2013-01-01 22:24 ` Junio C Hamano
2013-01-03 8:37 ` Jeff King
2013-01-03 15:34 ` Junio C Hamano
2013-01-03 20:23 ` Jeff King
2013-01-03 20:34 ` Junio C Hamano
2013-01-03 20:36 ` Jeff King
2013-01-03 22:33 ` Junio C Hamano [this message]
2013-01-07 13:46 ` Jeff King
2012-12-29 10:40 ` [PATCH 2/3] do not write null sha1s to on-disk index Jonathan Nieder
2012-07-28 15:06 ` [PATCH 3/3] fsck: detect null sha1 in tree entries Jeff King
2012-07-29 22:15 ` [PATCH 0/3] null sha1 in trees Junio C Hamano
2012-07-30 15:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzk0pvqvu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).