git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list
Date: Wed, 05 Sep 2007 17:16:47 -0700	[thread overview]
Message-ID: <7vy7fkfy1c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070905232251.GC331@nomad.office.altlinux.org> (Dmitry V. Levin's message of "Thu, 6 Sep 2007 03:22:51 +0400")

"Dmitry V. Levin" <ldv@altlinux.org> writes:

> Some external projects (e.g. parsecvs) need cache-tree.h file.

Your patch shows that our Makefile has been lacking a necessary
dependency for a long time.  LIB_H is not "public headers list",
but more like "the headers everybody depends on", and the header
file should have been on that list.  Thanks.

I am however not convinced it is a good idea to treat libgit.a
as if it is a library.  It is not a library in the usual sense
of the word.  Originally we did libgit.a primarily so that we do
not have to list all the *.o dependencies in the Makefile out of
laziness ;-)

  reply	other threads:[~2007-09-06  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05 23:22 [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Dmitry V. Levin
2007-09-06  0:16 ` Junio C Hamano [this message]
2007-09-06  0:37   ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy7fkfy1c.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).