From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Nicolas Pitre <nico@cam.org>, Len Brown <lenb@kernel.org>,
Theodore Tso <tytso@mit.edu>,
git@vger.kernel.org
Subject: Re: warning: no common commits - slow pull
Date: Thu, 28 Feb 2008 09:52:57 -0800 [thread overview]
Message-ID: <7vy795j7d2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0802281026030.19665@iabervon.org> (Daniel Barkalow's message of "Thu, 28 Feb 2008 10:53:18 -0500 (EST)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> Actually, I just realized something which should have been obvious: when
> we reconnect, we get a list of the remote's refs, which we currently
> discard immediately. We should actually pass this list to fetch_pack() if
> we just reconnected, so that the client side always does the interaction
> with the right idea of the server's refs, and discard it afterwards. The
> fact that the user of transport_*() doesn't find out that the server
> side's refs change in the middle of the life cycle and can't find out in
> any way doesn't matter too much, so long as each actual connection is
> internally consistant. (And the situation is no different from how it used
> to be with git-fetch.sh: if you get a different mirror later, you may
> discover that the server now doesn't have refs that it seemed to
> advertize, but nothing weird happens.)
I think that would also be a valid way to solve this "stale idea
of what the other side has" and can replace my weatherbaloon
patch.
Another potential problem area is if find_common() does the
right thing when it is called for the second time. I did not
check if you clear COMMON, SEEN, COMPLETE etc. bits from the
object database before initiating the second round, but if you
didn't, I am afraid these bits left over from the primary
transfer might interfere the common ancestor discovery during
the second round.
next prev parent reply other threads:[~2008-02-28 17:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 1:07 warning: no common commits - slow pull Len Brown
2008-02-11 1:44 ` Junio C Hamano
2008-02-17 3:52 ` Daniel Barkalow
2008-02-17 14:57 ` Johannes Schindelin
2008-02-17 17:46 ` Daniel Barkalow
2008-02-17 17:54 ` Junio C Hamano
2008-02-17 19:27 ` Johannes Schindelin
2008-02-17 20:41 ` Daniel Barkalow
2008-02-11 1:53 ` Theodore Tso
2008-02-11 2:39 ` Len Brown
2008-02-11 2:49 ` Junio C Hamano
2008-02-11 3:55 ` Theodore Tso
2008-02-15 21:43 ` Len Brown
2008-02-16 21:22 ` Johannes Schindelin
2008-02-25 21:59 ` Florian Weimer
2008-02-25 23:32 ` Daniel Barkalow
2008-02-26 19:38 ` Len Brown
2008-02-26 20:47 ` Nicolas Pitre
2008-02-26 23:45 ` Daniel Barkalow
2008-02-27 5:12 ` Junio C Hamano
2008-02-27 6:29 ` Junio C Hamano
2008-02-27 19:28 ` Daniel Barkalow
2008-02-27 20:53 ` Junio C Hamano
2008-02-27 21:26 ` Daniel Barkalow
2008-02-28 0:43 ` Shawn O. Pearce
2008-02-28 8:50 ` Shawn O. Pearce
2008-02-29 14:44 ` Jon Loeliger
2008-02-29 17:14 ` Daniel Barkalow
2008-02-28 0:47 ` Junio C Hamano
2008-02-28 15:53 ` Daniel Barkalow
2008-02-28 16:10 ` [PATCH] Always use the current connection's remote ref list in git protocol Daniel Barkalow
2008-02-28 17:52 ` Junio C Hamano [this message]
2008-02-28 18:36 ` warning: no common commits - slow pull Daniel Barkalow
2008-02-11 15:54 ` Florian Weimer
2008-02-11 21:13 ` Nix
-- strict thread matches above, loose matches on Subject: below --
2008-03-07 1:35 David Brownell
2008-03-08 1:22 ` Daniel Barkalow
2008-03-08 22:48 ` David Brownell
2008-03-08 22:58 ` Daniel Barkalow
2008-03-08 23:25 ` David Brownell
2008-03-08 23:27 ` Daniel Barkalow
2008-03-09 18:47 ` Daniel Barkalow
2008-03-10 17:18 ` David Brownell
2008-03-10 17:40 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy795j7d2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=nico@cam.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).