From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] zero-initialize object_info structs
Date: Sun, 07 Jul 2013 10:34:18 -0700 [thread overview]
Message-ID: <7vy59i46lh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130707100329.GA19143@sigill.intra.peff.net> (Jeff King's message of "Sun, 7 Jul 2013 06:03:29 -0400")
Jeff King <peff@peff.net> writes:
> Obviously I plan to add a new query type in the next patch, but this
> initialization is probably a reasonable thing to be doing anyway.
Yes. Thanks.
>
> sha1_file.c | 2 +-
> streaming.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sha1_file.c b/sha1_file.c
> index 0af19c0..de06a97 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2428,7 +2428,7 @@ int sha1_object_info(const unsigned char *sha1, unsigned long *sizep)
>
> int sha1_object_info(const unsigned char *sha1, unsigned long *sizep)
> {
> - struct object_info oi;
> + struct object_info oi = {0};
>
> oi.sizep = sizep;
> return sha1_object_info_extended(sha1, &oi);
> diff --git a/streaming.c b/streaming.c
> index cabcd9d..cac282f 100644
> --- a/streaming.c
> +++ b/streaming.c
> @@ -135,7 +135,7 @@ struct git_istream *open_istream(const unsigned char *sha1,
> struct stream_filter *filter)
> {
> struct git_istream *st;
> - struct object_info oi;
> + struct object_info oi = {0};
> const unsigned char *real = lookup_replace_object(sha1);
> enum input_source src = istream_source(real, type, &oi);
next prev parent reply other threads:[~2013-07-07 17:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 10:01 [RFC/PATCH 0/4] cat-file --batch-disk-sizes Jeff King
2013-07-07 10:03 ` [PATCH 1/4] zero-initialize object_info structs Jeff King
2013-07-07 17:34 ` Junio C Hamano [this message]
2013-07-07 10:04 ` [PATCH 2/4] teach sha1_object_info_extended a "disk_size" query Jeff King
2013-07-07 10:09 ` [PATCH 3/4] cat-file: add --batch-disk-sizes option Jeff King
2013-07-07 17:49 ` Junio C Hamano
2013-07-07 18:19 ` Jeff King
2013-07-08 11:04 ` Duy Nguyen
2013-07-08 12:00 ` Ramkumar Ramachandra
2013-07-08 13:13 ` Duy Nguyen
2013-07-08 13:37 ` Ramkumar Ramachandra
2013-07-09 2:55 ` Duy Nguyen
2013-07-09 10:32 ` Ramkumar Ramachandra
2013-07-10 11:16 ` Jeff King
2013-07-08 16:40 ` Junio C Hamano
2013-07-10 11:04 ` Jeff King
2013-07-11 16:35 ` Junio C Hamano
2013-07-07 21:15 ` brian m. carlson
2013-07-10 10:57 ` Jeff King
2013-07-07 10:14 ` [PATCH 4/4] pack-revindex: radix-sort the revindex Jeff King
2013-07-07 23:52 ` Shawn Pearce
2013-07-08 7:57 ` Jeff King
2013-07-08 15:38 ` Shawn Pearce
2013-07-08 20:50 ` Brandon Casey
2013-07-08 21:35 ` Brandon Casey
2013-07-10 10:57 ` Jeff King
2013-07-10 10:52 ` Jeff King
2013-07-10 11:34 ` [PATCHv2 00/10] cat-file formats/on-disk sizes Jeff King
2013-07-10 11:35 ` [PATCH 01/10] zero-initialize object_info structs Jeff King
2013-07-10 11:35 ` [PATCH 02/10] teach sha1_object_info_extended a "disk_size" query Jeff King
2013-07-10 11:36 ` [PATCH 03/10] t1006: modernize output comparisons Jeff King
2013-07-10 11:38 ` [PATCH 04/10] cat-file: teach --batch to stream blob objects Jeff King
2013-07-10 11:38 ` [PATCH 05/10] cat-file: refactor --batch option parsing Jeff King
2013-07-10 11:45 ` [PATCH 06/10] cat-file: add --batch-check=<format> Jeff King
2013-07-10 11:57 ` Eric Sunshine
2013-07-10 14:51 ` Ramkumar Ramachandra
2013-07-11 11:24 ` Jeff King
2013-07-10 11:46 ` [PATCH 07/10] cat-file: add %(objectsize:disk) format atom Jeff King
2013-07-10 11:48 ` [PATCH 08/10] cat-file: split --batch input lines on whitespace Jeff King
2013-07-10 15:29 ` Ramkumar Ramachandra
2013-07-11 11:36 ` Jeff King
2013-07-11 17:42 ` Junio C Hamano
2013-07-11 20:45 ` [PATCHv3 " Jeff King
2013-07-10 11:50 ` [PATCH 09/10] pack-revindex: use unsigned to store number of objects Jeff King
2013-07-10 11:55 ` [PATCH 10/10] pack-revindex: radix-sort the revindex Jeff King
2013-07-10 12:00 ` Jeff King
2013-07-10 13:17 ` Ramkumar Ramachandra
2013-07-11 11:03 ` Jeff King
2013-07-10 17:10 ` Brandon Casey
2013-07-11 11:17 ` Jeff King
2013-07-11 12:16 ` [PATCHv3 " Jeff King
2013-07-11 21:12 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy59i46lh.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).