From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: git bugs
Date: Tue, 10 Jun 2008 17:20:04 -0700
Message-ID: <7vwskwbz63.fsf@gitster.siamese.dyndns.org>
References: <832adb090806100141n69c086a2v2f59fe94b2f4ead3@mail.gmail.com>
 <alpine.LFD.1.10.0806101028040.3101@woody.linux-foundation.org>
 <832adb090806101145w55729676ya7bcfb41b0413f59@mail.gmail.com>
 <alpine.LFD.1.10.0806101249580.3101@woody.linux-foundation.org>
 <832adb090806101609q17a21948nb5814c3b22bd832d@mail.gmail.com>
 <7v1w34dfn3.fsf@gitster.siamese.dyndns.org>
 <832adb090806101702l79aba80cvba1eaab029e9ecd5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Daniel Barkalow" <barkalow@iabervon.org>, git@vger.kernel.org
To: "Ben Lynn" <benlynn@gmail.com>
X-From: git-owner@vger.kernel.org Wed Jun 11 02:21:25 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1K6E5d-0003VO-9W
	for gcvg-git-2@gmane.org; Wed, 11 Jun 2008 02:21:25 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753752AbYFKAUb (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 10 Jun 2008 20:20:31 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754698AbYFKAUb
	(ORCPT <rfc822;git-outgoing>); Tue, 10 Jun 2008 20:20:31 -0400
Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:57343 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753674AbYFKAUa (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 10 Jun 2008 20:20:30 -0400
Received: from localhost.localdomain (localhost [127.0.0.1])
	by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 14143582A;
	Tue, 10 Jun 2008 20:20:28 -0400 (EDT)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with
 ESMTPSA id 44F245826; Tue, 10 Jun 2008 20:20:20 -0400 (EDT)
In-Reply-To: <832adb090806101702l79aba80cvba1eaab029e9ecd5@mail.gmail.com>
 (Ben Lynn's message of "Tue, 10 Jun 2008 17:02:31 -0700")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
X-Pobox-Relay-ID: 31A18D6A-374C-11DD-BC56-F9737025C2AA-77302942!a-sasl-fastnet.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/84564>

"Ben Lynn" <benlynn@gmail.com> writes:

> ... I'm making the same
> assumptions, i.e. files are not touched while they're being indexed.

Actually you are making another assumption that is somewhat worrysome.

The filesystem clock and time(2) clock can be skewed and comparing a
timestamp you obtain from lstat(2) and time(2) might not give you any
meaningful information.  That is why I made this codepath without using
time(2) when I did the racy-git work.