git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jeff King <peff@peff.net>,
	Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH] t3703: add test cases for pathspec magic
Date: Sat, 07 May 2011 11:56:46 -0700	[thread overview]
Message-ID: <7vwri2wd8x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1304764507-27547-1-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Sat, 7 May 2011 17:35:07 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> That was the intention, but it raises a question: what do we do if a
> file happens to have the same name with the given magic pathspec, as
> in the last two tests?

I would have expected that in such a case the user would pass a "\:" or
even ":::" to match the file ":", and "\:(rubbish)" to match the file
":(rubbish)".  The whole ":" is special thing comes from the observation
that a path that begins with a colon is rare, so it is Ok to require the
user to do some more work (typing an extra backslash) when he really wants
to match with such a thing.

A script that takes a pathname that is meant to be a literal from the user
in its variable $x would pass ":(noglob)$x" when it wants to be strict.  A
script that lets the user say whatever and wants to pass would just pass
"$x" along the callchain.

I do not expect this to be an issue in practice, though.  Have you seen a
script that tries to quote all the possible globbing characters in "$x"
before calling into git with the current codebase without this magic?

  reply	other threads:[~2011-05-07 18:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-07 10:35 [PATCH] t3703: add test cases for pathspec magic Nguyễn Thái Ngọc Duy
2011-05-07 18:56 ` Junio C Hamano [this message]
2011-05-08  9:59   ` Nguyen Thai Ngoc Duy
2011-05-08 11:08 ` [PATCH] t3703, t4208: add test cases for magic pathspec Nguyễn Thái Ngọc Duy
2011-05-08 17:59   ` Junio C Hamano
2011-05-09 12:33     ` Nguyen Thai Ngoc Duy
2011-05-09 16:18       ` Junio C Hamano
2011-05-09 22:06       ` Junio C Hamano
2011-05-10  5:51   ` [PATCH 0/9] magic pathspec updates Junio C Hamano
2011-05-10  5:51     ` [PATCH 1/9] grep: use get_pathspec() correctly Junio C Hamano
2011-05-10  5:51     ` [PATCH 2/9] get_pathspec(): an empty ':' pathspec should stand alone Junio C Hamano
2011-05-10  5:51     ` [PATCH 3/9] count_pathspec(): return number of elements in pathspec Junio C Hamano
2011-05-10 13:29       ` Nguyen Thai Ngoc Duy
2011-05-10  5:51     ` [PATCH 4/9] add ":" is a pathspec that is too wide Junio C Hamano
2011-05-10  5:51     ` [PATCH 5/9] git rm ":" is like specifying nothing Junio C Hamano
2011-05-10  5:51     ` [PATCH 6/9] clean " Junio C Hamano
2011-05-10 15:14       ` Thiago Farina
2011-05-10  5:51     ` [PATCH 7/9] mv ":" ":" is like moving nothing from nowhere to nowhere Junio C Hamano
2011-05-10 13:30       ` Nguyen Thai Ngoc Duy
2011-05-10  5:51     ` [PATCH 8/9] checkout ":" is not giving any pathspec Junio C Hamano
2011-05-10  5:51     ` [PATCH 9/9] t3703, t4208: add test cases for magic pathspec Junio C Hamano
2011-05-12  8:21       ` [PATCH jc/magic-pathspec] t3703: Skip tests using directory name ":" on Windows Johannes Sixt
2011-05-29 18:29       ` [PATCH 9/9] t3703, t4208: add test cases for magic pathspec Ævar Arnfjörð Bjarmason
2011-05-29 20:31         ` Junio C Hamano
2011-05-29 20:36           ` Ævar Arnfjörð Bjarmason
2011-05-10 13:47     ` [PATCH 0/9] magic pathspec updates Nguyen Thai Ngoc Duy
2011-05-10 17:07       ` Junio C Hamano
2011-05-11 12:11         ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwri2wd8x.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).