From: Junio C Hamano <gitster@pobox.com>
To: Andrew Wong <andrew.kw.w@gmail.com>
Cc: git@vger.kernel.org, szeder@ira.uka.de, paulus@samba.org
Subject: Re: [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5
Date: Mon, 01 Oct 2012 10:27:56 -0700 [thread overview]
Message-ID: <7vwqzacdb7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1349105191-31681-2-git-send-email-andrew.kw.w@gmail.com> (Andrew Wong's message of "Mon, 1 Oct 2012 11:26:31 -0400")
Andrew Wong <andrew.kw.w@gmail.com> writes:
> The same workaround was used for Shift-F4 in:
> cea07cf8dc9b3677e0c50433c0d72bce83adbdc7
>
> Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
> ---
> gitk-git/gitk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index d93bd99..698b84a 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2496,6 +2496,7 @@ proc makewindow {} {
> bindkey f nextfile
> bind . <F5> updatecommits
> bind . <Shift-F5> reloadcommits
> + catch { bind . <Shift-Key-XF86_Switch_VT_5> reloadcommits }
> bind . <F2> showrefs
> bind . <Shift-F4> {newview 0}
> catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }
Wouldn't it make more sense to have a small helper function to wrap
binding both <Shift-Fn> and <Shift-Key-XF86_Switch_VT_n> to the same
thing and have F4 and F5 binding use that to avoid repetition?
next prev parent reply other threads:[~2012-10-01 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 10:19 gitk: can't reload commits with new key binding SZEDER Gábor
2012-10-01 15:26 ` Andrew Wong
2012-10-01 15:26 ` [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
2012-10-01 17:27 ` Junio C Hamano [this message]
2012-10-02 15:04 ` [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding Andrew Wong
2012-10-02 15:04 ` [PATCH v2 1/2] gitk: Refactor code for binding modified function keys Andrew Wong
2012-10-02 15:04 ` [PATCH v2 2/2] gitk: Use bindshiftfunctionkey to bind Shift-F5 Andrew Wong
2012-10-07 21:18 ` [PATCH v2 0/2] Re: gitk: can't reload commits with new key binding Andrew Wong
2012-10-08 21:05 ` SZEDER Gábor
2012-10-12 14:17 ` Andrew Wong
2012-10-21 22:19 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2012-10-01 15:16 [PATCH] gitk: Add workaround for system where Shift-F5 mapped to Shift-XF86_Switch_VT_5 Andrew Wong
2012-10-01 15:16 ` Andrew Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqzacdb7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=andrew.kw.w@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).