From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow generating a non-default set of documentation
Date: Sun, 07 Oct 2012 15:40:19 -0700 [thread overview]
Message-ID: <7vwqz1oqi4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121007214855.GB1743@sigill.intra.peff.net> (Jeff King's message of "Sun, 7 Oct 2012 17:48:56 -0400")
Jeff King <peff@peff.net> writes:
> On Sun, Oct 07, 2012 at 01:39:32PM -0700, Junio C Hamano wrote:
> ...
>> but it is not so far-fetched to imagine that Windows users may want to
>> omit manpages with
>>
>> $ DEFAULT_DOC_TARGET=html make doc
>
> That use case makes a lot more sense to me (or more likely setting it in
> config.mak).
I actually had "ifeq ($(uname_S),Windows)" at the top-level in mind,
not config.mak. I think that is far more important use case than
going down to Documentation yourself and run make there (which is
not a workflow I deeply care about in the first place).
>> Makefile | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> No change to Documentation/Makefile? So this will work:
>
> $ echo DEFAULT_DOC_TARGET=html >config.mak
> $ make doc
>
> but this will not:
>
> $ cd Documentation
> $ make
>
> Why not do it like this:
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 267dfe1..ca10313 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -152,7 +152,8 @@ endif
> endif
> endif
>
> -all: html man
> +DEFAULT_DOC_TARGET ?= html man
> +all: $(DEFAULT_DOC_TARGET)
>
> html: $(DOC_HTML)
>
>
> which covers both cases? That is also how we handle DEFAULT_TEST_TARGET.
>
> -Peff
next prev parent reply other threads:[~2012-10-07 22:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 20:39 [PATCH] Allow generating a non-default set of documentation Junio C Hamano
2012-10-07 21:48 ` Jeff King
2012-10-07 22:32 ` Junio C Hamano
2012-10-07 22:45 ` Junio C Hamano
2012-10-07 23:01 ` Jeff King
2012-10-07 22:40 ` Junio C Hamano [this message]
2012-10-07 23:07 ` Jeff King
2012-10-07 23:11 ` Jeff King
2012-10-07 23:25 ` Junio C Hamano
2012-10-07 23:29 ` Jeff King
2012-10-07 23:44 ` Junio C Hamano
2012-10-08 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqz1oqi4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).