git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git@vger.kernel.org, tim.henigan@gmail.com,
	Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH] Fix typo in remote set-head usage
Date: Mon, 26 Nov 2012 10:16:52 -0800	[thread overview]
Message-ID: <7vwqx8rzzf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1353851019-27254-1-git-send-email-apelisse@gmail.com> (Antoine Pelisse's message of "Sun, 25 Nov 2012 14:43:39 +0100")

Antoine Pelisse <apelisse@gmail.com> writes:

> parenthesis are not matching in `builtin_remote_sethead_usage`
> as a square bracket is closing something never opened.
> ---
> This will also break all translation files, should I also send a patch
> to update them ?

"git grep -A2 -e 'remote set-head <name>' po/" tells me that we
already have both the correct variant and the broken one, and they
are both translated ;-) so I do not think we have much to worry
about the i18n fallout in this case, but thanks anyway for thinking
about it.

You would need to sign off your patch, but otherwise looks good to
me.

Thanks.


>
> Cheers,
> Antoine Pelisse
>
>  builtin/remote.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/remote.c b/builtin/remote.c
> index a5a4b23..937484d 100644
> --- a/builtin/remote.c
> +++ b/builtin/remote.c
> @@ -39,7 +39,7 @@ static const char * const builtin_remote_rm_usage[] = {
>  };
>
>  static const char * const builtin_remote_sethead_usage[] = {
> -	N_("git remote set-head <name> (-a | -d | <branch>])"),
> +	N_("git remote set-head <name> (-a | -d | <branch>)"),
>  	NULL
>  };
>
> --
> 1.7.9.5

  reply	other threads:[~2012-11-26 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25 13:43 [PATCH] Fix typo in remote set-head usage Antoine Pelisse
2012-11-26 18:16 ` Junio C Hamano [this message]
2012-11-26 19:21   ` Antoine Pelisse
2012-11-26 21:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwqx8rzzf.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tim.henigan@gmail.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).