From: Junio C Hamano <gitster@pobox.com> To: Steven Klass <sklass@7stalks.com> Cc: "git\@vger.kernel.org" <git@vger.kernel.org>, spearce@spearce.org Subject: Re: [PATCH] Corrects an Abort Trap: 6 error with completions. Date: Mon, 08 Jul 2013 10:32:59 -0700 Message-ID: <7vwqp1yn1w.fsf@alter.siamese.dyndns.org> (raw) In-Reply-To: <5FF738AB-DA01-4460-9ADF-D960E2FD6309@7stalks.com> (Steven Klass's message of "Mon, 8 Jul 2013 06:58:33 -0700") Steven Klass <sklass@7stalks.com> writes: > Hi Folks, > > Corrects an Abort Trap: 6 error with completions. > Fixed an issue where the two commands on a single line would cause a strange unrelated 'Abort trap: 6' error on non-git commands on Mac OSX 10.8. > > Signed-off-by: Steven Klass <sklass@7stalks.com> Can you explain how/why the original causes "abort trap: 6" (whatever it is) and how/why the updated one avoids it in the log message? It also is not quite clear when the error happens. Do you mean, by "non-git commands", something like: $ ca<TAB> does not complete to "cal", "case", "cat", etc. and instead breaks the shell? I am confused. The only change I can see in the patch is that it makes the argument to this call to the __gitcomp shell function be a string with tokens separated by LF and HT and no SP (the original assumes that the tokens will be split by LF, HT or SP, and the shell function locally sets $IFS to make sure that the change in this patch does not make any difference). And in many other places in the same script, the __gitcomp shell function is called with an argument with LF, HT or SP spearated tokens, e.g. _git_add () { case "$cur" in --*) __gitcomp " --interactive --refresh --patch --update --dry-run --ignore-errors --intent-to-add " return esac > > --- > contrib/completion/git-completion.bash | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > mode change 100644 => 100755 contrib/completion/git-completion.bash > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > old mode 100644 > new mode 100755 > index 6c3bafe..d63b1ba > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -2165,7 +2165,8 @@ _git_config () > user.name > user.signingkey > web.browser > - branch. remote. > + branch. > + remote. > " > } > > --- > > Steven Klass > > (480) 225-1112 > sklass@7stalks.com > http://www.7stalks.com
next prev parent reply other threads:[~2013-07-08 17:33 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-08 13:58 Steven Klass 2013-07-08 17:32 ` Junio C Hamano [this message] 2013-07-08 17:45 ` Steven Klass
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7vwqp1yn1w.fsf@alter.siamese.dyndns.org \ --to=gitster@pobox.com \ --cc=git@vger.kernel.org \ --cc=sklass@7stalks.com \ --cc=spearce@spearce.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git