From: Junio C Hamano <gitster@pobox.com>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git@vger.kernel.org, Joern Hees <dev@joernhees.de>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] remote-hg: add shared repo upgrade
Date: Mon, 05 Aug 2013 14:02:14 -0700 [thread overview]
Message-ID: <7vwqnzj1gp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1375730567-3240-1-git-send-email-apelisse@gmail.com> (Antoine Pelisse's message of "Mon, 5 Aug 2013 21:22:47 +0200")
Antoine Pelisse <apelisse@gmail.com> writes:
> From: Felipe Contreras <felipe.contreras@gmail.com>
>
> 6796d49 (remote-hg: use a shared repository store) introduced a bug by
> making the shared repository '.git/hg', which is already used before
> that patch, so clones that happened before that patch, fail after that
> patch, because there's no shared Mercurial repo.
>
> It's trivial to upgrade to the new organization by copying the Mercurial
> repo from one of the remotes (e.g. 'origin'), so let's do so.
>
> ...
> + # check and upgrade old organization
> + hg_path = os.path.join(shared_path, '.hg')
> + if os.path.exists(shared_path) and not os.path.exists(hg_path):
> + repos = os.listdir(shared_path)
> + for x in repos:
> + local_hg = os.path.join(shared_path, x, 'clone', '.hg')
> + if not os.path.exists(local_hg):
> + continue
> + shutil.copytree(local_hg, hg_path)
The log message talks about "one of the remotes (e.g. 'origin')" and
you are creating a copy of one that you encounter in os.listdir(); I
may be missing some underlying assumptions but I wonder what happens
after you copy and create hg_path directory, which does not change
in the loop, to the remaining iterations of the loop. Is the untold
and obvious-to-those-who-are-familiar-with-this-codepath assumption
that it is guaranteed that there is at most one "*/clone/.hg" under
shared_path?
> + # setup shared repo (if not there)
> + try:
> + hg.peer(myui, {}, shared_path, create=True)
> + except error.RepoError:
> + pass
>
> if not os.path.exists(dirname):
> os.makedirs(dirname)
next prev parent reply other threads:[~2013-08-05 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 19:22 [PATCH] remote-hg: add shared repo upgrade Antoine Pelisse
2013-08-05 19:31 ` Felipe Contreras
2013-08-05 19:54 ` Antoine Pelisse
2013-08-05 21:02 ` Junio C Hamano [this message]
2013-08-06 6:22 ` Antoine Pelisse
2013-08-06 6:36 ` Junio C Hamano
2013-08-06 6:53 ` Antoine Pelisse
2013-08-09 16:49 ` [PATCH 1/2] " Antoine Pelisse
-- strict thread matches above, loose matches on Subject: below --
2013-08-05 19:29 [PATCH] " Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqnzj1gp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apelisse@gmail.com \
--cc=dev@joernhees.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).