From: Junio C Hamano <gitster@pobox.com>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] templates/Makefile: don't depend on local umask setting
Date: Thu, 28 Feb 2008 12:52:25 -0800 [thread overview]
Message-ID: <7vve48hkhi.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080228184442.13993.qmail@c0e6a439c34263.315fe32.mid.smarden.org
Gerrit Pape <pape@smarden.org> writes:
> Don't take the local umask setting into account when installing the
> templates/* files and directories, running 'make install' with umask set
> to 077 resulted in template/* installed with permissions 700 and 600.
Well spotted. As the current Makefile seems to assume the users
like 022 umask (existing "$(INSTALL) -d" uses "-m 755"), your
changes are consistent with it.
prev parent reply other threads:[~2008-02-28 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 18:44 [PATCH] templates/Makefile: don't depend on local umask setting Gerrit Pape
2008-02-28 20:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve48hkhi.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).