From: Junio C Hamano <gitster@pobox.com>
To: Denis Cheng <crquan@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] add pretty format configuration to git log/show/whatchanged
Date: Sat, 01 Mar 2008 22:20:17 -0800 [thread overview]
Message-ID: <7vve45tzoe.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vr6etvlgm.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 01 Mar 2008 19:44:25 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> In-tree, there are only two callers that do not use --pretty on the
> command line when calling these three commands:
>
> * "bisect visualize" calls "git log" when gitk is not available, with the
> user supplied formatting options. This is very much Ok --- we actively
> want your configuration feature for this caller.
>
> * "git merge --squash" calls "git log" to prepare the commit message
> template. This is _not_ Ok, and will be broken if we accept your
> patch.
>
> So you will need a preliminary patch to "git-merge" _before_ submitting
> this patch to make the latter codepath use "git log --pretty" instead.
> Doing so would have raised _my_ confidence level of the patch that you
> made your best effort not to introduce regression.
I should point out that I did not look at things outside shell scripts,
i.e. stuff I do not consider really the core part of the system. I did
not look at contrib/ area either.
I suspect the following have calls to show/log/whatchanged and do expect
to read the default format out of them, and can be broken by your patch:
* contrib/emacs/git.el (git-setup-commit-buffer)
* git-cvsserver.perl (sub update)
There also is a call to git log, but I think it is Ok.
* contrib/hooks/post-receive (generate_general_email)
You should not blindly trust nor take the above as an exhaustive list; it
is just from my quick survey.
next prev parent reply other threads:[~2008-03-02 6:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 19:44 [PATCH] pretty format now configurable Denis Cheng
2008-02-29 20:00 ` Linus Torvalds
2008-03-01 6:07 ` rae l
2008-03-01 17:15 ` [PATCH] add pretty format configuration to git log/show/whatchanged Denis Cheng
2008-03-01 18:22 ` Johannes Schindelin
2008-03-01 19:50 ` Denis Cheng
2008-03-02 3:44 ` Junio C Hamano
2008-03-02 6:20 ` Junio C Hamano [this message]
2008-03-02 9:05 ` [PATCH 1/3] whatchanged documentation: share description of --pretty with others Denis Cheng
2008-03-02 9:05 ` [PATCH 2/3] specify explicit "--pretty=medium" with `git log/show/whatchanged` Denis Cheng
2008-03-02 9:05 ` [PATCH 3/3] log/show/whatchanged: introduce format.pretty configuration Denis Cheng
2008-03-02 17:00 ` Junio C Hamano
2008-03-02 17:12 ` rae l
2008-03-02 17:00 ` [PATCH 2/3] specify explicit "--pretty=medium" with `git log/show/whatchanged` Junio C Hamano
2008-02-29 21:51 ` [PATCH] pretty format now configurable Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve45tzoe.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=crquan@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).